Fix and re-enable KioskTest.LaunchAppWithNetworkConfigAccelerator.

Fix and re-enable KioskTest.LaunchAppWithNetworkConfigAccelerator.

This test flaked whenever the app launching process finished before the
Ctrl+Alt+N accelerator is triggered by the test code. This race is fixed
by blocking the FILE thread until the accelerator has been performed,
so that the app loading can't proceed until the network screen is shown.

BUG=372995
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291054

[Joao da Silva, 2014-08-20 14:15:17]

Zel, git blame shows you as the original author. Can you have a look?

Bartosz, PTAL given our investigation today.

Thanks!

[bartfab (slow), 2014-08-20 14:45:29]

lgtm

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/kiosk_browsertest.cc (right):

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:144: void
LockAndUnlock(scoped_ptr<base::Lock> lock) {
Nit: #include "base/memory/scoped_ptr.h"

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:515: // Returns a lock that
is holding a task in the FILE thread. Any tasks posted
Nit: s/ in / on /

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:525:
content::BrowserThread::PostTask(
Nit: #include "content/public/browser/browser_thread.h"

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:526:
content::BrowserThread::FILE, FROM_HERE,
Nit: #include "base/location.h"

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:527:
base::Bind(&LockAndUnlock, base::Passed(&lock)));
Nit 1: #include "base/bind.h"
Nit 1: #include "base/bind_helpers.h"

[Joao da Silva, 2014-08-21 07:59:59]

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/kiosk_browsertest.cc (right):

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:144: void
LockAndUnlock(scoped_ptr<base::Lock> lock) {
On 2014/08/20 14:45:29, bartfab wrote:
> Nit: #include "base/memory/scoped_ptr.h"

Done.

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:515: // Returns a lock that
is holding a task in the FILE thread. Any tasks posted
On 2014/08/20 14:45:29, bartfab wrote:
> Nit: s/ in / on /

Done.

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:525:
content::BrowserThread::PostTask(
On 2014/08/20 14:45:29, bartfab wrote:
> Nit: #include "content/public/browser/browser_thread.h"

Done.

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:526:
content::BrowserThread::FILE, FROM_HERE,
On 2014/08/20 14:45:29, bartfab wrote:
> Nit: #include "base/location.h"

Done.

https://codereview.chromium.org/494693003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/kiosk_browsertest.cc:527:
base::Bind(&LockAndUnlock, base::Passed(&lock)));
On 2014/08/20 14:45:29, bartfab wrote:
> Nit 1: #include "base/bind.h"
> Nit 1: #include "base/bind_helpers.h"

Done.

[Joao da Silva, 2014-08-21 08:00:03]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-08-21 08:02:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/494693003/20001

[commit-bot: I haz the power, 2014-08-21 09:44:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-21 09:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 09:47:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Joao da Silva, 2014-08-21 11:09:14]

+Nikita for owner check

[Nikita (slow), 2014-08-21 12:01:49]

lgtm

[Joao da Silva, 2014-08-21 12:09:04]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2014-08-21 12:10:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/494693003/20001

[commit-bot: I haz the power, 2014-08-21 12:32:03]

Committed patchset #2 (20001) as 291054