Implement SkPicture::hasText() for SkRecord backend.

Implement SkPicture::hasText() for SkRecord backend.

Plus, some small tweaks to the existing code surrounding it.  Just proposals,
will undo whatever you don't like.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/c551d9fcae98ff7b9d56f315947e89a26632aeec

[mtklein, 2014-08-20 14:13:51]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-20 14:14:11]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/494683003/40001

[commit-bot: I haz the power, 2014-08-20 14:14:12]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-20 20:14 UTC

[commit-bot: I haz the power, 2014-08-20 14:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 14:14:16]

Presubmit check for 494683003-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[tomhudson, 2014-08-20 14:21:51]

I can live with losing constness of SkPicture::Analysis; we've hashed out more
than once our positions on it.

Not looking forward to having to merge the multiple iterations in the Analysis
constructor when it turns into a hotspot; hopefully that day never comes.

https://codereview.chromium.org/494683003/diff/40001/src/core/SkRecords.h
File src/core/SkRecords.h (right):

https://codereview.chromium.org/494683003/diff/40001/src/core/SkRecords.h#new...
src/core/SkRecords.h:67: M(DrawTextOnPath)                                      
        \
You broke alphabetical ordering to group text calls together? Dislike.

https://codereview.chromium.org/494683003/diff/40001/tests/PictureTest.cpp
File tests/PictureTest.cpp (right):

https://codereview.chromium.org/494683003/diff/40001/tests/PictureTest.cpp#ne...
tests/PictureTest.cpp:994: : recorder.             beginRecording(100, 100)
Hmm. I had a reviewer ask me to use one #define for the whole file, rather than
a different one (or the same cut-and-pasted) for each function that needed it.

I can go either way on that, but is it worth unifying the approach here with the
other two tests that do the same thing?

[tomhudson, 2014-08-20 14:35:03]

On 2014/08/20 14:21:51, tomhudson wrote:
> https://codereview.chromium.org/494683003/diff/40001/src/core/SkRecords.h
> File src/core/SkRecords.h (right):
> 
>
https://codereview.chromium.org/494683003/diff/40001/src/core/SkRecords.h#new...
> src/core/SkRecords.h:67: M(DrawTextOnPath)                                    
 
>         \
> You broke alphabetical ordering to group text calls together? Dislike.

In discussion, apparently this allows a significantly faster implementation in
practice.

LGTM

[reed1, 2014-08-20 14:39:37]

lgtm

[mtklein, 2014-08-20 14:44:05]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-20 14:44:14]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/494683003/40001

[mtklein, 2014-08-20 14:55:38]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-20 14:55:43]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/494683003/60001

[commit-bot: I haz the power, 2014-08-20 15:10:12]

Committed patchset #4 (60001) as c551d9fcae98ff7b9d56f315947e89a26632aeec