Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 494683002: Fix EstimateMarkingStepSizeTest. (Closed)

Created:
6 years, 4 months ago by ulan
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clamp to INT_MAX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/heap/gc-idle-time-handler.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ulan
PTAL
6 years, 4 months ago (2014-08-20 13:44:55 UTC) #1
wingo
This change causes the tests to pass on my side.
6 years, 4 months ago (2014-08-20 13:52:48 UTC) #2
wingo
On 2014/08/20 13:52:48, wingo wrote: > This change causes the tests to pass on my ...
6 years, 4 months ago (2014-08-20 13:55:42 UTC) #3
ulan
On 2014/08/20 13:55:42, wingo wrote: > On 2014/08/20 13:52:48, wingo wrote: > > This change ...
6 years, 4 months ago (2014-08-20 14:09:22 UTC) #4
wingo
Thanks Ulan, non-owner LGTM
6 years, 4 months ago (2014-08-20 14:18:54 UTC) #5
ulan
Committed patchset #2 manually as 23237 (presubmit successful).
6 years, 4 months ago (2014-08-20 14:21:07 UTC) #6
Hannes Payer (out of office)
6 years, 4 months ago (2014-08-20 15:38:26 UTC) #7
Message was sent while issue was closed.
The multiplication causes undefined behavior on int overflow. I landed a proper
fix in v8 revision 23248.

Powered by Google App Engine
This is Rietveld 408576698