Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 494653002: Move HTMLTable*Element.insert{Row,Cell}'s argument default into IDL file (Closed)

Created:
6 years, 4 months ago by Jens Widell
Modified:
6 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move HTMLTable*Element.insert{Row,Cell}'s argument default into IDL file They each take an index argument, that should default to -1. This matches the specification, and doesn't change behavior since these defaults were already implemented in the C++ code. BUG=258153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M Source/core/html/HTMLTableElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/HTMLTableElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableRowElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableSectionElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jens Widell
And another one... :-)
6 years, 4 months ago (2014-08-20 13:04:55 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-20 13:37:54 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-20 14:04:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/494653002/1
6 years, 4 months ago (2014-08-20 14:05:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-20 15:01:51 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 15:39:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180656

Powered by Google App Engine
This is Rietveld 408576698