Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

Issue 494633003: UMA: How often are different network error screens encountered during OOBE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
index 7e423efc398afbfb9b8e4436f8c9c0d9cb1c8896..00e98413e3a8ab9183c87cf69191b28e56f825c8 100644
--- a/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/browsing_data/browsing_data_helper.h"
#include "chrome/browser/browsing_data/browsing_data_remover.h"
+#include "chrome/browser/chromeos/login/error_screens_histogram_helper.h"
#include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
#include "chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.h"
#include "chrome/browser/extensions/signin/gaia_auth_extension_loader.h"
@@ -116,6 +117,7 @@ EnrollmentScreenHandler::EnrollmentScreenHandler(
frame_error_(net::OK),
network_state_informer_(network_state_informer),
error_screen_actor_(error_screen_actor),
+ histogram_helper_(new ErrorScreensHistogramHelper("Enrollment")),
weak_ptr_factory_(this) {
set_async_assets_load_id(OobeUI::kScreenOobeEnrollment);
DCHECK(network_state_informer_.get());
@@ -497,6 +499,7 @@ void EnrollmentScreenHandler::SetupAndShowOfflineMessage(
&params,
base::Bind(&EnrollmentScreenHandler::DoShow,
weak_ptr_factory_.GetWeakPtr()));
+ histogram_helper_->OnErrorShow(error_screen_actor_->error_state());
}
}
@@ -505,6 +508,7 @@ void EnrollmentScreenHandler::HideOfflineMessage(
ErrorScreenActor::ErrorReason reason) {
if (IsEnrollmentScreenHiddenByError())
error_screen_actor_->Hide();
+ histogram_helper_->OnErrorHide();
}
void EnrollmentScreenHandler::OnFrameError(
@@ -598,6 +602,7 @@ void EnrollmentScreenHandler::DoShow() {
screen_data.SetString("management_domain", management_domain_);
ShowScreen(OobeUI::kScreenOobeEnrollment, &screen_data);
+ histogram_helper_->OnScreenShow();
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698