Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc

Issue 494633003: UMA: How often are different network error screens encountered during OOBE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
index 5cbb2a4f1124924256bb862bea8f5076ef54fa20..df68da7d982d8a0f02d8eff84cb24b388ef59170 100644
--- a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
+++ b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
@@ -9,6 +9,7 @@
#include "base/rand_util.h"
#include "base/values.h"
#include "chrome/browser/chromeos/camera_detector.h"
+#include "chrome/browser/chromeos/login/error_screens_histogram_helper.h"
#include "chrome/browser/chromeos/login/existing_user_controller.h"
#include "chrome/browser/chromeos/login/screen_manager.h"
#include "chrome/browser/chromeos/login/screens/error_screen.h"
@@ -106,6 +107,7 @@ SupervisedUserCreationScreen::SupervisedUserCreationScreen(
image_decoder_(NULL),
apply_photo_after_decoding_(false),
selected_image_(0),
+ histogram_helper_(new ErrorScreensHistogramHelper("Supervised")),
weak_factory_(this) {
DCHECK(actor_);
if (actor_)
@@ -143,6 +145,7 @@ void SupervisedUserCreationScreen::Show() {
if (!on_error_screen_)
NetworkPortalDetector::Get()->AddAndFireObserver(this);
on_error_screen_ = false;
+ histogram_helper_->OnScreenShow();
}
void SupervisedUserCreationScreen::OnPageSelected(const std::string& page) {
@@ -154,12 +157,14 @@ void SupervisedUserCreationScreen::OnPortalDetectionCompleted(
const NetworkPortalDetector::CaptivePortalState& state) {
if (state.status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_ONLINE) {
get_screen_observer()->HideErrorScreen(this);
+ histogram_helper_->OnErrorHide();
} else {
on_error_screen_ = true;
ErrorScreen* screen = get_screen_observer()->GetErrorScreen();
ConfigureErrorScreen(screen, network, state.status);
screen->SetUIState(ErrorScreen::UI_STATE_SUPERVISED);
get_screen_observer()->ShowErrorScreen();
+ histogram_helper_->OnErrorShow(screen->GetErrorState());
}
}

Powered by Google App Engine
This is Rietveld 408576698