Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2226)

Unified Diff: chrome/browser/chromeos/login/screens/update_screen.cc

Issue 494633003: UMA: How often are different network error screens encountered during OOBE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/update_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/update_screen.cc b/chrome/browser/chromeos/login/screens/update_screen.cc
index 940c28f8e437f03e8f11ec2e4bbc0b25e6025425..4541f2ac82cc31e35f14f92d86969c6e7c0b12e0 100644
--- a/chrome/browser/chromeos/login/screens/update_screen.cc
+++ b/chrome/browser/chromeos/login/screens/update_screen.cc
@@ -11,6 +11,7 @@
#include "base/logging.h"
#include "base/message_loop/message_loop.h"
#include "base/threading/thread_restrictions.h"
+#include "chrome/browser/chromeos/login/error_screens_histogram_helper.h"
#include "chrome/browser/chromeos/login/screen_manager.h"
#include "chrome/browser/chromeos/login/screens/error_screen.h"
#include "chrome/browser/chromeos/login/screens/screen_observer.h"
@@ -107,6 +108,7 @@ UpdateScreen::UpdateScreen(ScreenObserver* screen_observer,
remora_controller_(remora_controller),
is_first_detection_notification_(true),
is_first_portal_notification_(true),
+ histogram_helper_(new ErrorScreensHistogramHelper("Update")),
weak_factory_(this) {
DCHECK(actor_);
if (actor_)
@@ -303,6 +305,7 @@ void UpdateScreen::CancelUpdate() {
void UpdateScreen::Show() {
is_shown_ = true;
+ histogram_helper_->OnScreenShow();
if (actor_) {
actor_->Show();
actor_->SetProgress(kBeforeUpdateCheckProgress);
@@ -496,11 +499,13 @@ void UpdateScreen::ShowErrorMessage() {
state_ = STATE_ERROR;
GetErrorScreen()->SetUIState(ErrorScreen::UI_STATE_UPDATE);
get_screen_observer()->ShowErrorScreen();
+ histogram_helper_->OnErrorShow(GetErrorScreen()->GetErrorState());
}
void UpdateScreen::HideErrorMessage() {
LOG(WARNING) << "UpdateScreen::HideErrorMessage()";
get_screen_observer()->HideErrorScreen(this);
+ histogram_helper_->OnErrorHide();
}
void UpdateScreen::UpdateErrorMessage(

Powered by Google App Engine
This is Rietveld 408576698