chrome/browser/chromeos/login/screens/error_screen.h - Issue 494633003: UMA: How often are different network error screens encountered during OOBE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screens/error_screen.h

Issue 494633003: UMA: How often are different network error screens encountered during OOBE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update after review Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/error_screens_histogram_helper_unittest.cc ('k') | chrome/browser/chromeos/login/screens/error_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screens/error_screen.h

diff --git a/chrome/browser/chromeos/login/screens/error_screen.h b/chrome/browser/chromeos/login/screens/error_screen.h

index 1c61eba32bf61b091753cb7af1fd718410c18e2b..b653b977d518727d812a18de7930cea8ed8dbce4 100644

--- a/chrome/browser/chromeos/login/screens/error_screen.h

+++ b/chrome/browser/chromeos/login/screens/error_screen.h

@@ -41,7 +41,10 @@ class ErrorScreen : public BaseScreen,

ERROR_STATE_OFFLINE,

ERROR_STATE_PROXY,

ERROR_STATE_AUTH_EXT_TIMEOUT,

- ERROR_STATE_KIOSK_ONLINE

+ ERROR_STATE_NONE,

+ // States above are being logged to histograms.

+ // Please keep ERROR_STATE_NONE as the last one of the histogram values.

+ ERROR_STATE_KIOSK_ONLINE,

};

ErrorScreen(ScreenObserver* screen_observer, ErrorScreenActor* actor);

@@ -87,6 +90,8 @@ class ErrorScreen : public BaseScreen,

// |error_state|, and |network|.

void SetErrorState(ErrorState error_state, const std::string& network);

+ ErrorState GetErrorState() const;

// Toggles the guest sign-in prompt.

void AllowGuestSignin(bool allow);