Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Unified Diff: chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc

Issue 494633003: UMA: How often are different network error screens encountered during OOBE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
diff --git a/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc b/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
index 273bbc41078ae188fa42a4d86c375d274dd6e6e2..87f10acfa36e2c778bc2e9da115852c5c99572a4 100644
--- a/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
+++ b/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
@@ -8,6 +8,7 @@
#include "base/bind_helpers.h"
#include "base/command_line.h"
#include "base/logging.h"
+#include "chrome/browser/chromeos/login/error_screens_histogram_helper.h"
#include "chrome/browser/chromeos/login/screen_manager.h"
#include "chrome/browser/chromeos/login/screens/screen_observer.h"
#include "chrome/browser/chromeos/login/wizard_controller.h"
@@ -31,7 +32,8 @@ AutoEnrollmentCheckScreen::AutoEnrollmentCheckScreen(
actor_(actor),
captive_portal_status_(
NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_UNKNOWN),
- auto_enrollment_state_(policy::AUTO_ENROLLMENT_STATE_IDLE) {
+ auto_enrollment_state_(policy::AUTO_ENROLLMENT_STATE_IDLE),
+ histogram_helper_(new ErrorScreensHistogramHelper("Enrollment")) {
if (actor_)
actor_->SetDelegate(this);
}
@@ -85,6 +87,7 @@ void AutoEnrollmentCheckScreen::Show() {
Start();
if (actor_)
actor_->Show();
+ histogram_helper_->OnScreenShow();
}
}
@@ -221,6 +224,7 @@ void AutoEnrollmentCheckScreen::ShowErrorScreen(
error_screen->SetErrorState(error_state,
network ? network->name() : std::string());
get_screen_observer()->ShowErrorScreen();
+ histogram_helper_->OnErrorShow(error_state);
}
void AutoEnrollmentCheckScreen::SignalCompletion() {

Powered by Google App Engine
This is Rietveld 408576698