Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6323)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 494633003: UMA: How often are different network error screens encountered during OOBE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index 5eeff9c7d255667564ddb44722582aaad0182063..1d0961d01cc4f83e208f354fcab21d73cab70a6d 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -29,6 +29,7 @@
#include "chrome/browser/chromeos/boot_times_loader.h"
#include "chrome/browser/chromeos/input_method/input_method_util.h"
#include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.h"
+#include "chrome/browser/chromeos/login/error_screens_histogram_helper.h"
#include "chrome/browser/chromeos/login/hwid_checker.h"
#include "chrome/browser/chromeos/login/lock/screen_locker.h"
#include "chrome/browser/chromeos/login/screens/core_oobe_actor.h"
@@ -276,6 +277,7 @@ SigninScreenHandler::SigninScreenHandler(
->GetImeKeyboard()
->CapsLockIsEnabled()),
gaia_screen_handler_(gaia_screen_handler),
+ histogram_helper_(new ErrorScreensHistogramHelper("Signin")),
weak_factory_(this) {
DCHECK(network_state_informer_.get());
DCHECK(error_screen_actor_);
@@ -444,6 +446,7 @@ void SigninScreenHandler::Show(const LoginScreenContext& context) {
}
gaia_screen_handler_->PopulateEmail(email);
ShowImpl();
+ histogram_helper_->OnScreenShow();
}
void SigninScreenHandler::ShowRetailModeLoginSpinner() {
@@ -688,6 +691,7 @@ void SigninScreenHandler::SetupAndShowOfflineMessage(
params.SetString("lastNetworkType", network_type);
error_screen_actor_->SetUIState(ErrorScreen::UI_STATE_SIGNIN);
error_screen_actor_->Show(OobeUI::SCREEN_GAIA_SIGNIN, &params);
+ histogram_helper_->OnErrorShow(error_screen_actor_->error_state());
}
}
@@ -698,6 +702,7 @@ void SigninScreenHandler::HideOfflineMessage(
return;
error_screen_actor_->Hide();
+ histogram_helper_->OnErrorHide();
// Forces a reload for Gaia screen on hiding error message.
if (IsGaiaVisible() || IsGaiaHiddenByError())

Powered by Google App Engine
This is Rietveld 408576698