Issue 49463006: chrome.windows.create should return new window id in Guest mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49463006: chrome.windows.create should return new window id in Guest mode (Closed)

Created:
7 years, 1 month ago by Dmitry Polukhin

Modified:
7 years, 1 month ago

Reviewers:
Matt Perry

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome.windows.create should return new window id in Guest mode Some context: Chrome OS Guest mode is incognito mode and user extensions are disabled but we have couple component extensions that work in Guest mode. QuickOffice is one of them. It uses incognito split mode and runs in incognito profile. CanCrossIncognito returns false if extension runs in not split mode. Therefore include_incognito is false. But in general there is no problem if chrome.windows.create return incognito window if extension itself already works in incognito mode. BUG=313789 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232931