GN: Build rules and fixes for (almost) all mojo unittest targets

GN: Build rules and fixes for (almost) all mojo unittest targets

This writes GN rules for all mojo unittests except for the ones that
depend on view_manager which doesn't have GN build rules yet. This also
fixes up a few deps in the gyp rules such as targets unnecessarily
depending on mojo_cpp_bindings or base.

R=viettrungluu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291022

[viettrungluu, 2014-08-20 16:44:45]

https://codereview.chromium.org/494523004/diff/1/mojo/public/cpp/environment/...
File mojo/public/cpp/environment/tests/BUILD.gn (right):

https://codereview.chromium.org/494523004/diff/1/mojo/public/cpp/environment/...
mojo/public/cpp/environment/tests/BUILD.gn:15: include_dirs = [ "../../../../.."
]
Is there a way to avoid this sort of thing (e.g., by having // in the default
list of include dirs)?

(Alternatively, is there a way to specify include dirs using an absolute path
instead (i.e., "//") instead?)

[jamesr, 2014-08-20 16:45:33]

On 2014/08/20 16:44:45, viettrungluu wrote:
>
https://codereview.chromium.org/494523004/diff/1/mojo/public/cpp/environment/...
> File mojo/public/cpp/environment/tests/BUILD.gn (right):
> 
>
https://codereview.chromium.org/494523004/diff/1/mojo/public/cpp/environment/...
> mojo/public/cpp/environment/tests/BUILD.gn:15: include_dirs = [
"../../../../.."
> ]
> Is there a way to avoid this sort of thing (e.g., by having // in the default
> list of include dirs)?

It could be a config

> 
> (Alternatively, is there a way to specify include dirs using an absolute path
> instead (i.e., "//") instead?)

I think that could work too.  Will poke...

[jamesr, 2014-08-20 19:19:14]

Don't need those at all as it turns out. PTAL.

[viettrungluu, 2014-08-20 19:52:51]

LGTM w/foo.

https://codereview.chromium.org/494523004/diff/20001/mojo/public/c/test_suppo...
File mojo/public/c/test_support/BUILD.gn (right):

https://codereview.chromium.org/494523004/diff/20001/mojo/public/c/test_suppo...
mojo/public/c/test_support/BUILD.gn:14: "../../tests/test_support_private.cc",
Could you add a "TODO(vtl): crbug.com/386799" comment here?

https://codereview.chromium.org/494523004/diff/20001/mojo/public/cpp/utility/...
File mojo/public/cpp/utility/tests/BUILD.gn (right):

https://codereview.chromium.org/494523004/diff/20001/mojo/public/cpp/utility/...
mojo/public/cpp/utility/tests/BUILD.gn:14: include_dirs = [ "../../../../.." ]
I don't think you need this, do you?

[jamesr, 2014-08-20 20:35:22]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-08-20 20:37:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/494523004/40001

[commit-bot: I haz the power, 2014-08-21 01:03:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-21 01:07:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 01:07:09]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[jamesr, 2014-08-21 03:54:36]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-08-21 03:56:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/494523004/40001

[commit-bot: I haz the power, 2014-08-21 08:35:37]

Committed patchset #3 (40001) as 291022