Expose IsSolidColor and write units tests

cc/resources/picture_pile.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/picture_pile.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 128 matching lines @@
   }
 
   *record_rects = vertical_clustering;
   return vertical_density;
 }
 
 }  // namespace
 
 namespace cc {
 
-PicturePile::PicturePile() : is_suitable_for_gpu_rasterization_(true) {}
+PicturePile::PicturePile()
+    : is_suitable_for_gpu_rasterization_(true),
+      is_solid_color_(true),
+      solid_color_(SK_ColorTRANSPARENT) {
+}
 
 PicturePile::~PicturePile() {
 }
 
 bool PicturePile::UpdateAndExpandInvalidation(
     ContentLayerClient* painter,
     Region* invalidation,
     SkColor background_color,
     bool contents_opaque,
     bool contents_fill_bounds_completely,
@@ skipping 226 matching lines @@
     for (TilingData::Iterator it(&tiling_, record_rect, include_borders); it;
          ++it) {
       const PictureMapKey& key = it.index();
       gfx::Rect tile = PaddedRect(key);
       if (record_rect.Contains(tile)) {
         PictureInfo& info = picture_map_[key];
         info.SetPicture(picture);
         found_tile_for_recorded_picture = true;
       }
     }
+    DetermineIfSolidColor();
     DCHECK(found_tile_for_recorded_picture);
   }
 
   has_any_recordings_ = true;
   DCHECK(CanRasterSlowTileCheck(recorded_viewport_));
   return true;
 }
 
 void PicturePile::SetEmptyBounds() {
   tiling_.SetTilingSize(gfx::Size());
   picture_map_.clear();
   has_any_recordings_ = false;
   recorded_viewport_ = gfx::Rect();
 }
 
+void PicturePile::DetermineIfSolidColor() {
+  is_solid_color_ = false;
+  solid_color_ = SK_ColorTRANSPARENT;
+
+  // determine if the entire picture map is pointing to the same image

[vmpstr, 2014/08/20 16:12:00]

style nit: Comments should be proper sentences (capitalization and a period at
the end)

[hendrikw, 2014/08/20 20:46:55]

Done.

+  if (picture_map_.empty()) {

[vmpstr, 2014/08/20 16:12:00]

We talked briefly about this yesterday: Is it possible that the picture_map_ is
empty? If not, this should be a DCHECK. I'm OK with handling it as well,
however. Up to you.

[hendrikw, 2014/08/20 20:46:55]

I think there are situations where the map could be empty.

+    is_solid_color_ = true;  // no pictures, we're solid 100% transparent
+    return;
+  }
+
+  const int kOpCountThatIsOkToAnalyze = 10;  // TODO(hendrikw) good value?

[vmpstr, 2014/08/20 16:12:00]

Looks like a good enough value. Can you put this in anonymous namespace near the
top of the file, please? Also as an FYI, typically we put TODOs above the line
:)

[hendrikw, 2014/08/20 20:46:55]

Done.

+  PictureMap::const_iterator it = picture_map_.begin();
+  Picture* picture = it->second.GetPicture();
+  DCHECK(picture);
+
+  // don't bother doing more work if the first image is too complicated
+  if (picture->GetApproximateOpCount() > kOpCountThatIsOkToAnalyze)
+    return;
+
+  // make sure all of the mapped images point to the same picture
+  while (++it != picture_map_.end()) {

[vmpstr, 2014/08/20 16:12:00]

I'd still prefer a for loop here:

for (++it; it != picture_map_.end(); ++it) {
 ...
}

[hendrikw, 2014/08/20 20:46:55]

Done.

+    if (it->second.GetPicture() != picture)
+      return;
+  }
+  skia::AnalysisCanvas canvas(recorded_viewport_.width(),
+                              recorded_viewport_.height());
+  picture->RasterForAnalysis(&canvas);
+  is_solid_color_ = canvas.GetColorIfSolid(&solid_color_);
+}
+
 }  // namespace cc