Issue 494483006: Remove chrome dependencies from app_window_api.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 494483006: Remove chrome dependencies from app_window_api.cc (Closed)

Created:
6 years, 4 months ago by hashimoto

Modified:
6 years, 3 months ago

Reviewers:
benwells

CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove chrome dependencies from app_window_api.cc Add OpenDevToolsWindow() and IsCurrentChannelOlderThanDev() to AppsClient. BUG=387288 Committed: https://crrev.com/1bba58e7ed1fdfb97d53f7ed26df5571c2e9d7c5 Cr-Commit-Position: refs/heads/master@{#291843}

Patch Set 1 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -40 lines)			Patch
M	apps/ui/apps_client.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/app_window/app_window_api.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/app_window/app_window_api.cc	View	6 chunks	+5 lines, -38 lines	0 comments	Download
M	chrome/browser/ui/apps/chrome_apps_client.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/apps/chrome_apps_client.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/494483006/40001

6 years, 4 months ago (2014-08-26 04:02:06 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (40001) as a6a2869fd807f76d8d4fb0d0e06d07e640a02fac

6 years, 4 months ago (2014-08-26 05:03:24 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:40:35 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1bba58e7ed1fdfb97d53f7ed26df5571c2e9d7c5
Cr-Commit-Position: refs/heads/master@{#291843}

Expand Messages | Collapse Messages