Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 494473003: Generalize screen getting/instantiation code. (Closed)

Created:
6 years, 4 months ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 3 months ago
Reviewers:
ygorshenin1
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Generalize screen getting/instantiation code. BUG=231331 R=ygorshenin@chromium.org Committed: https://crrev.com/a04fbdc989a3628fc3540466a8bc28437c523276 Cr-Commit-Position: refs/heads/master@{#293122}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -276 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.h View 1 4 chunks +9 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 8 chunks +88 lines, -131 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 28 chunks +81 lines, -110 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Denis Kuznetsov (DE-MUC)
6 years, 4 months ago (2014-08-25 16:38:11 UTC) #1
ygorshenin1
https://codereview.chromium.org/494473003/diff/1/chrome/browser/chromeos/login/wizard_controller.h File chrome/browser/chromeos/login/wizard_controller.h (left): https://codereview.chromium.org/494473003/diff/1/chrome/browser/chromeos/login/wizard_controller.h#oldcode136 chrome/browser/chromeos/login/wizard_controller.h:136: EulaScreen* GetEulaScreen(); Why did you delete some getters, but ...
6 years, 3 months ago (2014-08-26 14:18:53 UTC) #2
Denis Kuznetsov (DE-MUC)
https://codereview.chromium.org/494473003/diff/1/chrome/browser/chromeos/login/wizard_controller.h File chrome/browser/chromeos/login/wizard_controller.h (left): https://codereview.chromium.org/494473003/diff/1/chrome/browser/chromeos/login/wizard_controller.h#oldcode136 chrome/browser/chromeos/login/wizard_controller.h:136: EulaScreen* GetEulaScreen(); On 2014/08/26 14:18:53, ygorshenin1 wrote: > Why ...
6 years, 3 months ago (2014-09-02 17:40:07 UTC) #3
ygorshenin1
lgtm
6 years, 3 months ago (2014-09-03 08:42:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/494473003/20001
6 years, 3 months ago (2014-09-03 10:35:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 603327ca2978d205f165f5b209fdd0761f31a1db
6 years, 3 months ago (2014-09-03 11:37:28 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:19 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a04fbdc989a3628fc3540466a8bc28437c523276
Cr-Commit-Position: refs/heads/master@{#293122}

Powered by Google App Engine
This is Rietveld 408576698