Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 494473002: Cleanup: Change const char* foo to const char foo[] in content/browser. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, michaeln, creis+watch_chromium.org, tzik, nasko+codewatch_chromium.org, jam, nhiroki, feature-media-reviews_chromium.org, darin-cc_chromium.org, kinuko+fileapi
Project:
chromium
Visibility:
Public.

Description

Cleanup: Change const char* foo to const char foo[] in content/browser. Otherwise |foo| can accidentally get reassigned. Also fix lint errors. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M content/browser/appcache/appcache_response_unittest.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/fileapi/chrome_blob_storage_context.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/host_zoom_map_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/webrtc_identity_store_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_identity_store_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-19 23:00:14 UTC) #1
Charlie Reis
LGTM
6 years, 4 months ago (2014-08-19 23:50:57 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-19 23:53:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/494473002/1
6 years, 4 months ago (2014-08-19 23:54:15 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-21 08:47:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/494473002/1
6 years, 4 months ago (2014-08-21 08:48:02 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 08:49:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 291024

Powered by Google App Engine
This is Rietveld 408576698