Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 494423002: Add testing flag for XPS for deterministic ids. (Closed)

Created:
6 years, 4 months ago by bungeman-skia
Modified:
6 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add testing flag for XPS for deterministic ids. BUG=skia:455 R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/da5a1b8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
M include/device/xps/SkXPSDevice.h View 2 chunks +14 lines, -0 lines 1 comment Download
M src/device/xps/SkXPSDevice.cpp View 7 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bungeman-skia
This is a first step, wanted to get this in an working. The next step ...
6 years, 4 months ago (2014-08-22 18:18:43 UTC) #1
mtklein
lgtm https://codereview.chromium.org/494423002/diff/1/include/device/xps/SkXPSDevice.h File include/device/xps/SkXPSDevice.h (right): https://codereview.chromium.org/494423002/diff/1/include/device/xps/SkXPSDevice.h#newcode186 include/device/xps/SkXPSDevice.h:186: decltype(GUID::Data1) fNextId = 0; Would prefer DWORD, whatever ...
6 years, 4 months ago (2014-08-22 18:23:34 UTC) #2
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-08-22 19:01:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/494423002/1
6 years, 4 months ago (2014-08-22 19:02:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 19:02:18 UTC) #5
commit-bot: I haz the power
Presubmit check for 494423002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-08-22 19:02:19 UTC) #6
bungeman-skia
6 years, 4 months ago (2014-08-22 19:07:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as da5a1b8.

Powered by Google App Engine
This is Rietveld 408576698