Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 494413002: Remove unused methods. (Closed)

Created:
6 years, 4 months ago by pals
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused methods. BUG=406236 Committed: https://crrev.com/a34319cf9aa976abc1fd76877fedd68f56eb7711 Cr-Commit-Position: refs/heads/master@{#296663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
pals
Blink side changes landed https://codereview.chromium.org/392993005/. Now, it is safe to remove the unused methods. PTAL.
6 years, 3 months ago (2014-09-24 06:34:01 UTC) #2
jamesr
lgtm, thanks for following up
6 years, 3 months ago (2014-09-24 06:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/494413002/1
6 years, 3 months ago (2014-09-24 06:37:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/18428)
6 years, 3 months ago (2014-09-24 06:48:48 UTC) #7
jamesr
Has the blink patch rolled in to chromium yet?
6 years, 3 months ago (2014-09-24 06:50:26 UTC) #8
pals
On 2014/09/24 06:50:26, jamesr wrote: > Has the blink patch rolled in to chromium yet? ...
6 years, 3 months ago (2014-09-24 07:11:12 UTC) #9
jamesr
http://www.chromium.org/blink/gardening describes the roll process. If you try again in a day or so it'll ...
6 years, 3 months ago (2014-09-24 07:24:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/494413002/1
6 years, 3 months ago (2014-09-25 05:18:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 29a6ca3cf3a69964db913925543bc7a32da93ee8
6 years, 3 months ago (2014-09-25 06:03:36 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 06:04:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a34319cf9aa976abc1fd76877fedd68f56eb7711
Cr-Commit-Position: refs/heads/master@{#296663}

Powered by Google App Engine
This is Rietveld 408576698