Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 494383003: Supervised users: Properly display long custodian emails in the disclaimer. (Closed)

Created:
6 years, 4 months ago by Marc Treib
Modified:
6 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Supervised users: Properly display long custodian emails in the disclaimer. This CL allows the disclaimer label to break within words, so that long emails will appear fully, rather than being cut off/elided. BUG=406359 Committed: https://crrev.com/e8d91bdd8edba0a5b10656758bbbb4860f228bdd Cr-Commit-Position: refs/heads/master@{#291702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Marc Treib
PTAL!
6 years, 4 months ago (2014-08-22 13:12:12 UTC) #1
msw
lgtm, but you should post before/after pics for UI changes.
6 years, 4 months ago (2014-08-22 18:28:36 UTC) #2
Marc Treib
On 2014/08/22 18:28:36, msw wrote: > lgtm, but you should post before/after pics for UI ...
6 years, 4 months ago (2014-08-25 14:04:24 UTC) #3
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-08-25 14:04:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/494383003/1
6 years, 4 months ago (2014-08-25 14:05:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-25 14:58:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 15:58:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/2523)
6 years, 4 months ago (2014-08-25 15:58:30 UTC) #8
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-08-25 16:16:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/494383003/1
6 years, 4 months ago (2014-08-25 16:17:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (1) as ba9691f4a26edb02b6077bff1249d07e3d66396c
6 years, 4 months ago (2014-08-25 17:05:36 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8d91bdd8edba0a5b10656758bbbb4860f228bdd
Cr-Commit-Position: refs/heads/master@{#291702}

Powered by Google App Engine
This is Rietveld 408576698