Issue 494363002: add tool generated whitespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 494363002: add tool generated whitespace (Closed)

Created:
6 years, 4 months ago by caryclark

Modified:
6 years, 4 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

add tool generated whitespace the rebaseline tool adds whitespace at the end of lines in the json file. While harmless, git flags this as something worth fixing. Fixing it causes the rebaseline tool to generate a new difference with the whitespace. Checking the whitespace back in to avoid future back-and-forth. TBR= NOTRY=true NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/fe9384910d402b6998e38cc61b063a25dbb43ab1

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/494363002/1

6 years, 4 months ago (2014-08-22 11:55:12 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-22 11:55:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (1) as fe9384910d402b6998e38cc61b063a25dbb43ab1

Expand Messages | Collapse Messages