Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1781)

Issue 494343002: Migrate test-semaphore to base-unittests. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Migrate test-semaphore to base-unittests. TEST=base-unittests BUG=v8:3489 LOG=n R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23296

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -157 lines) Patch
M test/base-unittests/base-unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/base-unittests/platform/semaphore-unittest.cc View 1 chunk +145 lines, -0 lines 3 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-semaphore.cc View 1 chunk +0 lines, -156 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-22 05:17:50 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/494343002/diff/1/test/base-unittests/platform/semaphore-unittest.cc File test/base-unittests/platform/semaphore-unittest.cc (right): https://codereview.chromium.org/494343002/diff/1/test/base-unittests/platform/semaphore-unittest.cc#newcode123 test/base-unittests/platform/semaphore-unittest.cc:123: EXPECT_FALSE(semaphore.WaitFor(TimeDelta::FromMicroseconds(1))); What's the difference to ASSERT_FALSE above? https://codereview.chromium.org/494343002/diff/1/test/base-unittests/platform/semaphore-unittest.cc#newcode133 ...
6 years, 4 months ago (2014-08-22 08:21:07 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/494343002/diff/1/test/base-unittests/platform/semaphore-unittest.cc File test/base-unittests/platform/semaphore-unittest.cc (right): https://codereview.chromium.org/494343002/diff/1/test/base-unittests/platform/semaphore-unittest.cc#newcode123 test/base-unittests/platform/semaphore-unittest.cc:123: EXPECT_FALSE(semaphore.WaitFor(TimeDelta::FromMicroseconds(1))); EXPECT_* just record a failure, while ASSERT_* terminates ...
6 years, 4 months ago (2014-08-22 08:51:58 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-22 08:52:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698