Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 494303004: fix and update debug-debugger.js (Closed)

Created:
6 years, 4 months ago by refack
Modified:
6 years, 3 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8@master
Project:
v8
Visibility:
Public.

Description

fix and update debug-debugger.js added `switch` statement is missing `break`s R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23441

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/debug-debugger.js View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
refack
6 years, 4 months ago (2014-08-25 18:57:50 UTC) #1
refack
The CQ bit was checked by refack@gmail.com
6 years, 4 months ago (2014-08-25 18:59:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/refack@gmail.com/494303004/1
6 years, 4 months ago (2014-08-25 18:59:49 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 18:59:50 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-25 18:59:50 UTC) #5
refack
refack@gmail.com changed reviewers: + yurys@chromium.org
6 years, 4 months ago (2014-08-25 19:02:39 UTC) #6
aandrey
aandrey@chromium.org changed reviewers: + aandrey@chromium.org, yangguo@chromium.org
6 years, 4 months ago (2014-08-25 19:04:30 UTC) #7
aandrey
6 years, 4 months ago (2014-08-25 19:04:31 UTC) #8
Yang
lgtm.
6 years, 4 months ago (2014-08-25 20:09:22 UTC) #9
refack
The CQ bit was checked by refack@gmail.com
6 years, 4 months ago (2014-08-25 20:21:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/refack@gmail.com/494303004/1
6 years, 4 months ago (2014-08-25 20:21:20 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 20:21:20 UTC) #12
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-25 20:21:21 UTC) #13
refack
refack@gmail.com changed reviewers: + adamk@chromium.org, rafaelw@chromium.org, rossberg@chromium.org
6 years, 3 months ago (2014-08-26 08:06:54 UTC) #14
refack
refack@gmail.com changed reviewers: + vsevik@chromium.org
6 years, 3 months ago (2014-08-26 08:25:37 UTC) #15
Yang
On 2014/08/26 08:25:37, refack wrote: > mailto:refack@gmail.com changed reviewers: > + mailto:vsevik@chromium.org You will need ...
6 years, 3 months ago (2014-08-26 08:59:41 UTC) #16
refack
On 2014/08/26 08:59:41, Yang wrote: > On 2014/08/26 08:25:37, refack wrote: > > mailto:refack@gmail.com changed ...
6 years, 3 months ago (2014-08-26 09:25:46 UTC) #17
vsevik
vsevik@chromium.org changed reviewers: - vsevik@chromium.org
6 years, 3 months ago (2014-08-27 08:10:47 UTC) #18
refack
On 2014/08/26 08:59:41, Yang wrote: > On 2014/08/26 08:25:37, refack wrote: > > mailto:refack@gmail.com changed ...
6 years, 3 months ago (2014-08-27 08:32:11 UTC) #19
Yang
On 2014/08/27 08:32:11, refack wrote: > On 2014/08/26 08:59:41, Yang wrote: > > On 2014/08/26 ...
6 years, 3 months ago (2014-08-27 08:55:12 UTC) #20
refack
On 2014/08/27 08:55:12, Yang wrote: > On 2014/08/27 08:32:11, refack wrote: > > On 2014/08/26 ...
6 years, 3 months ago (2014-08-27 09:18:40 UTC) #21
Yang
6 years, 3 months ago (2014-08-27 09:54:27 UTC) #22
Message was sent while issue was closed.
On 2014/08/27 09:18:40, refack wrote:
> On 2014/08/27 08:55:12, Yang wrote:
> > On 2014/08/27 08:32:11, refack wrote:
> > > On 2014/08/26 08:59:41, Yang wrote:
> > > > On 2014/08/26 08:25:37, refack wrote:
> > > > > mailto:refack@gmail.com changed reviewers:
> > > > > + mailto:vsevik@chromium.org
> > > > 
> > > > You will need to sign the individual CLA here:
> > > > https://developers.google.com/open-source/cla/individual?csw=1
> > > 
> > > Signed the CLA.
> > > Updated AUTHORS.
> > > Got an L.G.T.M.
> > > What should I do now?
> > 
> > nothing. I'll land this CL for you.
> Thanks.

Committed in r23441.

Powered by Google App Engine
This is Rietveld 408576698