|
|
Descriptionfix and update debug-debugger.js
added `switch` statement is missing `break`s
R=yangguo@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=23441
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 22 (0 generated)
The CQ bit was checked by refack@gmail.com
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/refack@gmail.com/494303004/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
refack@gmail.com changed reviewers: + yurys@chromium.org
aandrey@chromium.org changed reviewers: + aandrey@chromium.org, yangguo@chromium.org
lgtm.
The CQ bit was checked by refack@gmail.com
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/refack@gmail.com/494303004/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
refack@gmail.com changed reviewers: + adamk@chromium.org, rafaelw@chromium.org, rossberg@chromium.org
refack@gmail.com changed reviewers: + vsevik@chromium.org
On 2014/08/26 08:25:37, refack wrote: > mailto:refack@gmail.com changed reviewers: > + mailto:vsevik@chromium.org You will need to sign the individual CLA here: https://developers.google.com/open-source/cla/individual?csw=1
On 2014/08/26 08:59:41, Yang wrote: > On 2014/08/26 08:25:37, refack wrote: > > mailto:refack@gmail.com changed reviewers: > > + mailto:vsevik@chromium.org > > You will need to sign the individual CLA here: > https://developers.google.com/open-source/cla/individual?csw=1 Done
vsevik@chromium.org changed reviewers: - vsevik@chromium.org
On 2014/08/26 08:59:41, Yang wrote: > On 2014/08/26 08:25:37, refack wrote: > > mailto:refack@gmail.com changed reviewers: > > + mailto:vsevik@chromium.org > > You will need to sign the individual CLA here: > https://developers.google.com/open-source/cla/individual?csw=1 Signed the CLA. Updated AUTHORS. Got an L.G.T.M. What should I do now?
On 2014/08/27 08:32:11, refack wrote: > On 2014/08/26 08:59:41, Yang wrote: > > On 2014/08/26 08:25:37, refack wrote: > > > mailto:refack@gmail.com changed reviewers: > > > + mailto:vsevik@chromium.org > > > > You will need to sign the individual CLA here: > > https://developers.google.com/open-source/cla/individual?csw=1 > > Signed the CLA. > Updated AUTHORS. > Got an L.G.T.M. > What should I do now? nothing. I'll land this CL for you.
On 2014/08/27 08:55:12, Yang wrote: > On 2014/08/27 08:32:11, refack wrote: > > On 2014/08/26 08:59:41, Yang wrote: > > > On 2014/08/26 08:25:37, refack wrote: > > > > mailto:refack@gmail.com changed reviewers: > > > > + mailto:vsevik@chromium.org > > > > > > You will need to sign the individual CLA here: > > > https://developers.google.com/open-source/cla/individual?csw=1 > > > > Signed the CLA. > > Updated AUTHORS. > > Got an L.G.T.M. > > What should I do now? > > nothing. I'll land this CL for you. Thanks.
Message was sent while issue was closed.
On 2014/08/27 09:18:40, refack wrote: > On 2014/08/27 08:55:12, Yang wrote: > > On 2014/08/27 08:32:11, refack wrote: > > > On 2014/08/26 08:59:41, Yang wrote: > > > > On 2014/08/26 08:25:37, refack wrote: > > > > > mailto:refack@gmail.com changed reviewers: > > > > > + mailto:vsevik@chromium.org > > > > > > > > You will need to sign the individual CLA here: > > > > https://developers.google.com/open-source/cla/individual?csw=1 > > > > > > Signed the CLA. > > > Updated AUTHORS. > > > Got an L.G.T.M. > > > What should I do now? > > > > nothing. I'll land this CL for you. > Thanks. Committed in r23441. |