Add a minimum cross axis size to BoxLayout.

Add a minimum cross axis size to BoxLayout.

This CL allows clients to specify a minimum cross axis size when using
a BoxLayout.

BUG=406983
Committed: https://crrev.com/d1b26261efa014efe4a98e9dfb5ce2f510b6a8d5
Cr-Commit-Position: refs/heads/master@{#292299}

[Matt Giuca, 2014-08-26 02:38:23]

I don't think I'm an appropriate reviewer for this. Can you add one of the views
people?

[calamity, 2014-08-26 02:55:05]

calamity@chromium.org changed reviewers:
+ benwells@chromium.org

[calamity, 2014-08-26 02:55:05]

Ok, sending to Ben for local review. This is necessary for
https://codereview.chromium.org/463403003/ .

[calamity, 2014-08-26 02:55:28]

calamity@chromium.org changed reviewers:
- mgiuca@chromium.org

[benwells, 2014-08-26 07:22:16]

https://codereview.chromium.org/494273003/diff/1/ui/views/layout/box_layout.cc
File ui/views/layout/box_layout.cc (left):

https://codereview.chromium.org/494273003/diff/1/ui/views/layout/box_layout.c...
ui/views/layout/box_layout.cc:172: int child_width = width -
NonChildSize(host).width();
Why has this changed?

[calamity, 2014-08-26 08:38:24]

https://codereview.chromium.org/494273003/diff/1/ui/views/layout/box_layout.cc
File ui/views/layout/box_layout.cc (left):

https://codereview.chromium.org/494273003/diff/1/ui/views/layout/box_layout.c...
ui/views/layout/box_layout.cc:172: int child_width = width -
NonChildSize(host).width();
On 2014/08/26 07:22:16, benwells wrote:
> Why has this changed?

Removed.

[benwells, 2014-08-26 22:05:51]

lgtm

https://codereview.chromium.org/494273003/diff/20001/ui/views/layout/box_layo...
File ui/views/layout/box_layout.cc (right):

https://codereview.chromium.org/494273003/diff/20001/ui/views/layout/box_layo...
ui/views/layout/box_layout.cc:165: width = std::max(width,
minimum_cross_axis_size_);
Nit: initialize minimum_cross_axis_size_

[calamity, 2014-08-27 03:59:33]

calamity@chromium.org changed reviewers:
+ sky@chromium.org

[calamity, 2014-08-27 03:59:33]

https://codereview.chromium.org/494273003/diff/20001/ui/views/layout/box_layo...
File ui/views/layout/box_layout.cc (right):

https://codereview.chromium.org/494273003/diff/20001/ui/views/layout/box_layo...
ui/views/layout/box_layout.cc:165: width = std::max(width,
minimum_cross_axis_size_);
On 2014/08/26 22:05:51, benwells wrote:
> Nit: initialize minimum_cross_axis_size_

Done.

[calamity, 2014-08-27 04:00:34]

+sky for OWNERS.

[sky, 2014-08-27 14:38:42]

LGTM

[calamity, 2014-08-28 00:06:02]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-08-28 00:07:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/494273003/40001

[commit-bot: I haz the power, 2014-08-28 01:19:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-08-28 01:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 01:47:12]

Failed to commit the patch.

[calamity, 2014-08-28 02:31:04]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-08-28 02:32:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/494273003/40001

[commit-bot: I haz the power, 2014-08-28 02:33:26]

Committed patchset #3 (id:40001) as b76bfbb135507694214f0dbd39dd311d01f44ea7

[commit-bot: I haz the power, 2014-09-10 02:56:44]

Patchset 3 (id:??) landed as
https://crrev.com/d1b26261efa014efe4a98e9dfb5ce2f510b6a8d5
Cr-Commit-Position: refs/heads/master@{#292299}