Issue 494263003: Undo a rename of dbus::Message::GetSignature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 494263003: Undo a rename of dbus::Message::GetSignature. (Closed)

Created:
6 years, 4 months ago by Ben Chan

Modified:
6 years, 3 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Undo a rename of dbus::Message::GetSignature. dbus::Message::GetSignature() was incorrectly renamed to dbus::Message::GetDataSigature() in https://codereview.chromium.org/502793002. This CL undoes that. BUG=None TEST=dbus_unittests Committed: https://crrev.com/5d15ab5892635c504e8efff9c81e4dd8dc3de492 Cr-Commit-Position: refs/heads/master@{#291660}

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	dbus/message.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	dbus/message.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/494263003/1

6 years, 4 months ago (2014-08-25 08:29:12 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-25 09:23:14 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as 641207f68459f3b7908eda7d310023f97be13924

6 years, 4 months ago (2014-08-25 11:17:05 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:33:44 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5d15ab5892635c504e8efff9c81e4dd8dc3de492
Cr-Commit-Position: refs/heads/master@{#291660}