OwnerKeyUtil is moved to components/ownership.

components/ownership/owner_key_util_impl.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_OWNERSHIP_OWNER_KEY_UTIL_IMPL_H_
+#define COMPONENTS_OWNERSHIP_OWNER_KEY_UTIL_IMPL_H_
+
+#include "base/basictypes.h"

[erikwright (departed), 2014/08/28 18:39:58]

what do you need from basictypes that's not in macros?

[ygorshenin1, 2014/08/28 18:59:05]

Nothing, I forget to remove it, sorry.

On 2014/08/28 18:39:58, erikwright wrote:

+#include "base/compiler_specific.h"
+#include "base/files/file_path.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"

[erikwright (departed), 2014/08/28 18:39:58]

not required.

[ygorshenin1, 2014/08/28 18:59:05]

Done.

+#include "components/ownership/owner_key_util.h"
+#include "components/ownership/ownership_export.h"
+
+namespace ownership {
+
+class OWNERSHIP_EXPORT OwnerKeyUtilImpl : public OwnerKeyUtil {
+ public:
+  explicit OwnerKeyUtilImpl(const base::FilePath& public_key_file);
+
+  // Attempts to read the public key from the file system.  Upon success,
+  // returns true and populates |output|.  False on failure.

[erikwright (departed), 2014/08/28 18:39:58]

These comments should be in the pure-virtual file.

In this implementation, you should have:

// OwnerKeyUtil implementation
virtual bool ... OVERRIDE;
virtual ...
etc.

A class comment, and possibly a constructor comment, should explain any
implementation-specific details such as the fact that this class is
filesystem-backed.

[ygorshenin1, 2014/08/28 18:59:05]

Done.

+  virtual bool ImportPublicKey(std::vector<uint8>* output) OVERRIDE;
+
+#if defined(USE_NSS)
+  // Looks for the private key associated with |key| in the |slot|
+  // and returns it if it can be found.  Returns NULL otherwise.
+  // Caller takes ownership.
+  virtual crypto::RSAPrivateKey* FindPrivateKeyInSlot(
+      const std::vector<uint8>& key,
+      PK11SlotInfo* slot) OVERRIDE;
+#endif  // defined(USE_NSS)
+
+  // Checks whether the public key is present in the file system.
+  virtual bool IsPublicKeyPresent() OVERRIDE;
+
+ protected:
+  virtual ~OwnerKeyUtilImpl();

[erikwright (departed), 2014/08/28 18:39:58]

Since you don't have any 'friends' I guess this can be private.

[ygorshenin1, 2014/08/28 18:59:05]

Done.

+
+ private:
+  // The file that holds the public key.
+  base::FilePath public_key_file_;
+
+  DISALLOW_COPY_AND_ASSIGN(OwnerKeyUtilImpl);
+};
+
+}  // namespace ownership
+
+#endif  // COMPONENTS_OWNERSHIP_OWNER_KEY_UTIL_IMPL_H_