Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 494083002: Fix regression due to navigation refactoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 617aff7dfd8df9120ed83fb64781c1dc7c7ec8ea..ea9f921fc4de728d55746b0e285e3ddcd0d517ff 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -342,11 +342,7 @@ bool NavigatorImpl::NavigateToEntry(
// capture the time needed for the RenderFrameHost initialization.
base::TimeTicks navigation_start = base::TimeTicks::Now();
- // Create the navigation parameters.
FrameMsg_Navigate_Params navigate_params;
- MakeNavigateParams(
- entry, *controller_, reload_type, navigation_start, &navigate_params);
-
RenderFrameHostManager* manager =
render_frame_host->frame_tree_node()->render_manager();
@@ -355,6 +351,9 @@ bool NavigatorImpl::NavigateToEntry(
// node.
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBrowserSideNavigation)) {
+ // Create the navigation parameters.
+ MakeNavigateParams(
+ entry, *controller_, reload_type, navigation_start, &navigate_params);
return manager->RequestNavigation(entry, navigate_params);
}
@@ -374,6 +373,12 @@ bool NavigatorImpl::NavigateToEntry(
if (delegate_)
delegate_->AboutToNavigateRenderFrame(dest_render_frame_host);
+ // Create the navigation parameters.
+ // TODO(vitalybuka): Move this before AboutToNavigateRenderFrame once
+ // http://crbug.com/408684 is fixed.
+ MakeNavigateParams(
+ entry, *controller_, reload_type, navigation_start, &navigate_params);
+
// Navigate in the desired RenderFrameHost.
// We can skip this step in the rare case that this is a transfer navigation
// which began in the chosen RenderFrameHost, since the request has already
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698