Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/property-details.h

Issue 494063002: Rename IsDontDelete to IsConfigurable (and invert conditions) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/hydrogen-instructions.h ('K') | « src/property.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PROPERTY_DETAILS_H_ 5 #ifndef V8_PROPERTY_DETAILS_H_
6 #define V8_PROPERTY_DETAILS_H_ 6 #define V8_PROPERTY_DETAILS_H_
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 #include "src/allocation.h" 9 #include "src/allocation.h"
10 #include "src/utils.h" 10 #include "src/utils.h"
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 return FieldIndexField::decode(value_); 253 return FieldIndexField::decode(value_);
254 } 254 }
255 255
256 inline PropertyDetails AsDeleted() const; 256 inline PropertyDetails AsDeleted() const;
257 257
258 static bool IsValidIndex(int index) { 258 static bool IsValidIndex(int index) {
259 return DictionaryStorageField::is_valid(index); 259 return DictionaryStorageField::is_valid(index);
260 } 260 }
261 261
262 bool IsReadOnly() const { return (attributes() & READ_ONLY) != 0; } 262 bool IsReadOnly() const { return (attributes() & READ_ONLY) != 0; }
263 bool IsDontDelete() const { return (attributes() & DONT_DELETE) != 0; } 263 bool IsConfigurable() const { return (attributes() & DONT_DELETE) == 0; }
264 bool IsDontEnum() const { return (attributes() & DONT_ENUM) != 0; } 264 bool IsDontEnum() const { return (attributes() & DONT_ENUM) != 0; }
265 bool IsDeleted() const { return DeletedField::decode(value_) != 0;} 265 bool IsDeleted() const { return DeletedField::decode(value_) != 0;}
266 266
267 // Bit fields in value_ (type, shift, size). Must be public so the 267 // Bit fields in value_ (type, shift, size). Must be public so the
268 // constants can be embedded in generated code. 268 // constants can be embedded in generated code.
269 class TypeField: public BitField<PropertyType, 0, 3> {}; 269 class TypeField: public BitField<PropertyType, 0, 3> {};
270 class AttributesField: public BitField<PropertyAttributes, 3, 3> {}; 270 class AttributesField: public BitField<PropertyAttributes, 3, 3> {};
271 271
272 // Bit fields for normalized objects. 272 // Bit fields for normalized objects.
273 class DeletedField: public BitField<uint32_t, 6, 1> {}; 273 class DeletedField: public BitField<uint32_t, 6, 1> {};
(...skipping 22 matching lines...) Expand all
296 PropertyDetails(int value, PropertyAttributes attributes) { 296 PropertyDetails(int value, PropertyAttributes attributes) {
297 value_ = AttributesField::update(value, attributes); 297 value_ = AttributesField::update(value, attributes);
298 } 298 }
299 299
300 uint32_t value_; 300 uint32_t value_;
301 }; 301 };
302 302
303 } } // namespace v8::internal 303 } } // namespace v8::internal
304 304
305 #endif // V8_PROPERTY_DETAILS_H_ 305 #endif // V8_PROPERTY_DETAILS_H_
OLDNEW
« src/hydrogen-instructions.h ('K') | « src/property.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698