Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 493973002: [Password Generation] Use correct URL for web password manager. (Closed)

Created:
6 years, 4 months ago by Garrett Casto
Modified:
6 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Use correct URL for web password manager. BUG=405747 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Garrett Casto
6 years, 4 months ago (2014-08-20 23:50:29 UTC) #1
Ilya Sherman
LGTM
6 years, 4 months ago (2014-08-21 00:12:24 UTC) #2
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 4 months ago (2014-08-21 00:18:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/493973002/1
6 years, 4 months ago (2014-08-21 00:19:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 01:37:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 01:40:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55439)
6 years, 4 months ago (2014-08-21 01:40:53 UTC) #7
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 4 months ago (2014-08-21 20:40:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/493973002/1
6 years, 4 months ago (2014-08-21 20:48:16 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:44:37 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (1) as 291200

Powered by Google App Engine
This is Rietveld 408576698