Componentize component_updater: Move a bunch of tests to component.

components/component_updater/test/component_patcher_unittest.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_TEST_COMPONENT_PATCHER_UNITTEST_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_TEST_COMPONENT_PATCHER_UNITTEST_H_
 
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
-#include "chrome/common/chrome_paths.h"
 #include "content/public/test/test_browser_thread_bundle.h"

[Sorin Jianu, 2014/08/22 17:19:58]

Is it ok to have this content dependency here and in other unit tests in
src/components/component_updater ?

[tommycli, 2014/08/22 17:31:45]

Yes, I think the tests can use content/. The tests don't run on iOS.

I think there's other components where the production code doesn't use content/
and the tests do.

That being said, it would be nice to remove content/ from the tests. Separate
CL?

[Sorin Jianu, 2014/08/22 17:35:44]

Separate CL sg.

 #include "courgette/courgette.h"
 #include "courgette/third_party/bsdiff.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace component_updater {
 
 class MockComponentPatcher;
 class ReadOnlyTestInstaller;
 
 const char binary_output_hash[] =
@@ skipping 11 matching lines @@
   scoped_ptr<ReadOnlyTestInstaller> installer_;
   scoped_refptr<base::SequencedTaskRunner> task_runner_;
 
  private:
   content::TestBrowserThreadBundle thread_bundle_;
 };
 
 }  // namespace component_updater
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_TEST_COMPONENT_PATCHER_UNITTEST_H_