Componentize component_updater: Move a bunch of tests to component.

chrome/chrome_tests_unit.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'targets': [
     {
       # This target contains mocks and test utilities that don't belong in
       # production libraries but are used by more than one test executable.
       'target_name': 'test_support_common',
       'type': 'static_library',
       'dependencies': [
         # NOTE: New dependencies should generally be added in the OS!="ios"
         # dependencies block below, rather than here.
         'browser',
         'chrome_resources.gyp:chrome_resources',
         'chrome_resources.gyp:chrome_strings',
         'chrome_resources.gyp:theme_resources',
         'common',
         '../base/base.gyp:base_prefs_test_support',
         '../base/base.gyp:test_support_base',
         '../components/components.gyp:bookmarks_test_support',
+        '../components/components.gyp:component_updater_test_support',

[Sorin Jianu, 2014/08/22 17:19:58]

Tommy, do you know if we could further refactor the code so that we will not
have this component_updater_test_support?

I imagine this is needed since it is used in two places by the unit tests. Would
it be possible to further consolidate the code?

[tommycli, 2014/08/22 17:31:44]

Two ways:

a) you could bake the test support stuff CU in general, but i don't recommend
this.

b) As you mentioned, separate out the CUS test from the CU Resource Throttle
test and move one. You probably need to do more work...

         '../components/components.gyp:gcm_driver_test_support',
         '../components/components.gyp:history_core_test_support',
         '../components/components.gyp:invalidation',
         '../components/components.gyp:invalidation_test_support',
         '../components/components.gyp:metrics_test_support',
         '../components/components.gyp:omnibox_test_support',
         '../components/components.gyp:password_manager_core_browser_test_support',
         '../components/components.gyp:pref_registry_test_support',
         '../components/components.gyp:search_engines_test_support',
         '../components/components.gyp:signin_core_browser_test_support',
@@ skipping 755 matching lines @@
         'browser/chromeos/settings/owner_key_util_unittest.cc',
         'browser/chromeos/settings/session_manager_operation_unittest.cc',
         'browser/chromeos/settings/stub_cros_settings_provider_unittest.cc',
         'browser/chromeos/system/automatic_reboot_manager_unittest.cc',
         'browser/chromeos/timezone/timezone_unittest.cc',
         'browser/chromeos/ui/idle_app_name_notification_view_unittest.cc',
         'browser/chromeos/version_loader_unittest.cc',
         'browser/command_updater_unittest.cc',
         'browser/component_updater/test/cld_component_installer_unittest.cc',
         'browser/component_updater/test/component_installers_unittest.cc',
-        'browser/component_updater/test/component_patcher_unittest.cc',
-        'browser/component_updater/test/component_updater_ping_manager_unittest.cc',
         'browser/component_updater/test/component_updater_service_unittest.cc',
-        'browser/component_updater/test/crx_downloader_unittest.cc',
-        'browser/component_updater/test/test_configurator.cc',
-        'browser/component_updater/test/test_installer.cc',
-        'browser/component_updater/test/update_checker_unittest.cc',
-        'browser/component_updater/test/update_response_unittest.cc',
-        'browser/component_updater/test/url_request_post_interceptor.cc',
         'browser/content_settings/content_settings_default_provider_unittest.cc',
         'browser/content_settings/content_settings_mock_observer.cc',
         'browser/content_settings/content_settings_mock_observer.h',
         'browser/content_settings/content_settings_mock_provider.cc',
         'browser/content_settings/content_settings_mock_provider.h',
         'browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc',
         'browser/content_settings/content_settings_policy_provider_unittest.cc',
         'browser/content_settings/content_settings_pref_provider_unittest.cc',
         'browser/content_settings/content_settings_provider_unittest.cc',
         'browser/content_settings/content_settings_rule_unittest.cc',
@@ skipping 2071 matching lines @@
               'dependencies': [
                 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
               ],
             }],
           ],
         },
       ],
     }],
   ],  # 'conditions'
 }