Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 493923003: Nuke support for running MSan without a simulator. (Closed)

Created:
6 years, 3 months ago by earthdok
Modified:
6 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, eugenis
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

Nuke support for running MSan without a simulator. We've abandoned that approach. The ARM64 simulator is the only supported way of running V8 under MSan. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/heap/spaces.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/msan.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
earthdok
6 years, 3 months ago (2014-08-26 11:31:54 UTC) #1
earthdok
ping?
6 years, 3 months ago (2014-09-11 14:28:08 UTC) #2
Jakob Kummerow
(sorry, vacation-induced delay). LGTM, will land.
6 years, 3 months ago (2014-09-11 14:29:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/493923003/1
6 years, 3 months ago (2014-09-11 14:31:57 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-11 14:31:58 UTC) #7
Jakob Kummerow
6 years, 3 months ago (2014-09-11 15:19:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698