Remove DistilledPageInfo and related structs.

Remove DistilledPageInfo and related structs.

The DistilledPageInfo and related structs are unnecessary, and it is possible
to pass the DomDistillerResult proto around instead. Currently they contain the
same data, and it is all just copied over.

Removing this intermediate step simplifies the code and makes it easier to add
more data to the DomDistillerResult proto and passing it through to
DistilledPageProto.

BUG=409274
Committed: https://crrev.com/3d9a246947c3a01ca075a4c7eca4cda4259a4939
Cr-Commit-Position: refs/heads/master@{#293008}

[nyquist, 2014-08-26 00:02:38]

nyquist@chromium.org changed reviewers:
+ cjhopman@chromium.org

[nyquist, 2014-08-26 00:02:38]

cjhopman: PTAL

[cjhopman, 2014-08-27 19:11:37]

https://codereview.chromium.org/493853006/diff/1/components/dom_distiller/cor...
File components/dom_distiller/core/distiller_page.cc (right):

https://codereview.chromium.org/493853006/diff/1/components/dom_distiller/cor...
components/dom_distiller/core/distiller_page.cc:87: found_content));
found_content should probably be false if we failed to parse the proto

[nyquist, 2014-08-28 19:01:32]

cjhopman: PTAL

https://codereview.chromium.org/493853006/diff/1/components/dom_distiller/cor...
File components/dom_distiller/core/distiller_page.cc (right):

https://codereview.chromium.org/493853006/diff/1/components/dom_distiller/cor...
components/dom_distiller/core/distiller_page.cc:87: found_content));
On 2014/08/27 19:11:37, cjhopman wrote:
> found_content should probably be false if we failed to parse the proto

Done.

[nyquist, 2014-08-28 21:30:12]

sorry about the churn... now PTAL :-)

[cjhopman, 2014-08-28 21:58:53]

https://codereview.chromium.org/493853006/diff/60001/components/dom_distiller...
File components/dom_distiller/core/distiller_page.cc (right):

https://codereview.chromium.org/493853006/diff/60001/components/dom_distiller...
components/dom_distiller/core/distiller_page.cc:82: value,
distiller_result.get());
If we just use the old version of ReadFromValue here then we won't depend on the
change to the protoc plugin in dom distiller js (and can just add the
ReadFromValue switch with the roll instead of this whole change).

[nyquist, 2014-08-28 22:08:56]

removed dependency. PTAL

[nyquist, 2014-08-28 22:09:15]

https://codereview.chromium.org/493853006/diff/60001/components/dom_distiller...
File components/dom_distiller/core/distiller_page.cc (right):

https://codereview.chromium.org/493853006/diff/60001/components/dom_distiller...
components/dom_distiller/core/distiller_page.cc:82: value,
distiller_result.get());
On 2014/08/28 21:58:53, cjhopman wrote:
> If we just use the old version of ReadFromValue here then we won't depend on
the
> change to the protoc plugin in dom distiller js (and can just add the
> ReadFromValue switch with the roll instead of this whole change).

Done.

[cjhopman, 2014-08-28 22:16:28]

lgtm

[nyquist, 2014-08-28 22:43:38]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2014-08-28 22:45:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nyquist@chromium.org/493853006/80001

[commit-bot: I haz the power, 2014-08-28 22:56:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47859)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/53199)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-28 22:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 22:58:09]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47863)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)

[nyquist, 2014-08-29 23:33:02]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2014-08-29 23:36:54]

The CQ bit was unchecked by nyquist@chromium.org

[nyquist, 2014-08-29 23:40:30]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2014-08-29 23:54:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nyquist@chromium.org/493853006/100001

[commit-bot: I haz the power, 2014-08-30 01:14:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-30 01:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-30 01:29:08]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[nyquist, 2014-09-02 20:39:33]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2014-09-02 20:41:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nyquist@chromium.org/493853006/120001

[commit-bot: I haz the power, 2014-09-02 21:47:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-02 22:18:03]

Committed patchset #7 (id:120001) as 1f4809f26b34c78f1ab4e51593a5690404d009a2

[commit-bot: I haz the power, 2014-09-10 03:21:16]

Patchset 7 (id:??) landed as
https://crrev.com/3d9a246947c3a01ca075a4c7eca4cda4259a4939
Cr-Commit-Position: refs/heads/master@{#293008}