Issue 493853004: Revert of Stop all PeerConnections upon suspend from Blink side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 493853004: Revert of Stop all PeerConnections upon suspend from Blink side (Closed)

Created:
6 years, 4 months ago by scottmg

Modified:
6 years, 3 months ago

Reviewers:
vrk (LEFT CHROMIUM), jiayl

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Stop all PeerConnections upon suspend from Blink side (patchset #3 of https://codereview.chromium.org/475263002/) Reason for revert: Causing browser crashes due to race, BUG=404767 Original issue's description: > Stop all PeerConnections upon suspend from Blink side > > BUG=403618 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291213 TBR=jiayl@chromium.org,vrk@chromium.org NOTREECHECKS=true NOTRY=true BUG=403618

Patch Set 1 #

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -8 lines)			Patch
M	content/renderer/media/peer_connection_tracker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/rtc_peer_connection_handler.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/media/rtc_peer_connection_handler.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

Created Revert of Stop all PeerConnections upon suspend from Blink side

6 years, 4 months ago (2014-08-25 22:46:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/493853004/1

6 years, 4 months ago (2014-08-25 22:48:58 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-25 22:50:52 UTC) #4

The CQ bit was unchecked by commit-bot@chromium.org

Expand Messages | Collapse Messages