Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: ui/keyboard/BUILD.gn

Issue 493833002: GN: Enable ui/keyboard:keyboard_unittests, fix up webui targets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/BUILD.gn ('k') | ui/keyboard/webui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/BUILD.gn
diff --git a/ui/keyboard/BUILD.gn b/ui/keyboard/BUILD.gn
index 8321077d0c04077b3fe7e7bb6b173427c12ef3a4..d528115731abe7b45c126117624b8f8849af5cd9 100644
--- a/ui/keyboard/BUILD.gn
+++ b/ui/keyboard/BUILD.gn
@@ -31,8 +31,6 @@ component("keyboard") {
"//base",
"//base/third_party/dynamic_annotations",
"//content/public/browser",
- "//ipc",
- "//skia",
"//url",
"//ui/aura",
"//ui/base",
@@ -40,6 +38,7 @@ component("keyboard") {
"//ui/events",
"//ui/gfx",
"//ui/gfx/geometry",
+ "//ui/keyboard/webui",
"//ui/wm",
]
}
@@ -71,10 +70,6 @@ copy("resources") {
forward_dependent_configs_from = deps
}
-# TODO(GYP) enable this when all dependencies are resolved. Some transitive
-# deps aren't done yet.
-if (false) {
-
test("keyboard_unittests") {
sources = [
"test/run_all_unittests.cc",
@@ -101,5 +96,3 @@ test("keyboard_unittests") {
"//url",
]
}
-
-}
« no previous file with comments | « ui/gl/BUILD.gn ('k') | ui/keyboard/webui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698