Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 493833002: GN: Enable ui/keyboard:keyboard_unittests, fix up webui targets (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

GN: Enable ui/keyboard:keyboard_unittests, fix up webui targets This adds the ui/keyboard:keyboard_unittests target to the GN build and adds the rest of ui/keyboard/webui/ to the build. Since the webui bits are the only parts that need mojo the mojo deps are restricted to that source set. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M ui/gl/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/keyboard/BUILD.gn View 4 chunks +1 line, -8 lines 0 comments Download
M ui/keyboard/webui/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
6 years, 4 months ago (2014-08-20 19:06:28 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-20 19:09:45 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-20 20:39:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/493833002/1
6 years, 4 months ago (2014-08-20 20:41:15 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 21:14:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 21:18:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55098)
6 years, 4 months ago (2014-08-20 21:18:25 UTC) #7
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-21 20:27:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/493833002/1
6 years, 4 months ago (2014-08-21 20:31:38 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:40:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 291199

Powered by Google App Engine
This is Rietveld 408576698