Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 493813002: Show MessageWindow from the background page (Closed)

Created:
6 years, 4 months ago by kelvinp
Modified:
6 years, 3 months ago
Reviewers:
Jamie, garykac, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/8df98f3682b0c3e6ceba6e51dd4ed74396c15ef0 Cr-Commit-Position: refs/heads/master@{#291719}

Patch Set 1 : Baseline for MessageWindow #

Patch Set 2 : Add support for confirm dialogs #

Total comments: 1

Patch Set 3 : Fix license header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+588 lines, -3 lines) Patch
M remoting/remoting_webapp_files.gypi View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
A remoting/webapp/background/message_window.js View 1 2 1 chunk +163 lines, -0 lines 0 comments Download
A remoting/webapp/background/message_window_helper.js View 1 2 1 chunk +271 lines, -0 lines 0 comments Download
A remoting/webapp/background/message_window_manager.js View 1 2 1 chunk +111 lines, -0 lines 0 comments Download
A remoting/webapp/html/message_window.html View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M remoting/webapp/js_proto/chrome_proto.js View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A + remoting/webapp/message_window.css View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
kelvinp
PTAL
6 years, 4 months ago (2014-08-20 19:42:26 UTC) #1
Jamie
lgtm
6 years, 4 months ago (2014-08-21 00:33:33 UTC) #2
kelvinp
The CQ bit was checked by kelvinp@chromium.org
6 years, 4 months ago (2014-08-21 02:10:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/493813002/40001
6 years, 4 months ago (2014-08-21 02:11:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 03:56:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 04:00:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5679)
6 years, 4 months ago (2014-08-21 04:00:24 UTC) #7
garykac
lgtm https://codereview.chromium.org/493813002/diff/40001/remoting/remoting_webapp_files.gypi File remoting/remoting_webapp_files.gypi (right): https://codereview.chromium.org/493813002/diff/40001/remoting/remoting_webapp_files.gypi#newcode239 remoting/remoting_webapp_files.gypi:239: 'webapp/html/message_window.html', When we add new html files, we ...
6 years, 4 months ago (2014-08-23 00:48:19 UTC) #8
kelvinp
The CQ bit was checked by kelvinp@chromium.org
6 years, 4 months ago (2014-08-25 17:13:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/493813002/60001
6 years, 4 months ago (2014-08-25 17:13:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 18:26:43 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
6 years, 4 months ago (2014-08-25 18:26:44 UTC) #12
kelvinp
The CQ bit was checked by kelvinp@chromium.org
6 years, 4 months ago (2014-08-25 18:30:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/493813002/60001
6 years, 4 months ago (2014-08-25 18:30:49 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 18:31:35 UTC) #15
commit-bot: I haz the power
Failed to apply patch for remoting/webapp/message_window.css: While running git apply --index -p1; error: remoting/webapp/message_window.css: already ...
6 years, 4 months ago (2014-08-25 18:31:35 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:53 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8df98f3682b0c3e6ceba6e51dd4ed74396c15ef0
Cr-Commit-Position: refs/heads/master@{#291719}

Powered by Google App Engine
This is Rietveld 408576698