Align SSLClientSocketOpenSSL and SSLClientSocketNSS histograms.

net/socket/ssl_client_socket_pool.cc

Index: net/socket/ssl_client_socket_pool.cc
diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc
index e54f79c929cee2b2eacb398bfa8896bcc64b212b..7b530ab3d87ebb5b3e6b65dfb65c0774fa8db945 100644
--- a/net/socket/ssl_client_socket_pool.cc
+++ b/net/socket/ssl_client_socket_pool.cc
@@ -501,6 +501,13 @@ int SSLConnectJob::DoSSLConnectComplete(int result) {
                                 SSLConnectionStatusToCipherSuite(
                                     ssl_info.connection_status));
 
+    if (ssl_info.connection_status &
+        SSL_CONNECTION_NO_RENEGOTIATION_EXTENSION) {
+      UMA_HISTOGRAM_ENUMERATION("Net.RenegotiationExtensionSupported", 0, 2);
+    } else {
+      UMA_HISTOGRAM_ENUMERATION("Net.RenegotiationExtensionSupported", 1, 2);

[Alexei Svitkine (slow), 2014/08/22 18:49:14]

Nit: Can you just use an UMA_HISTOGRAM_BOOLEAN() here?

Also, can you refactor to have a single macro invocation for the same histogram?
Each macro expands to a bunch of code, so fewer of them results in less bloat.

[davidben, 2014/08/22 23:03:20]

Done. Though, that should be flipped back if it isn't safe to flip an existing
0/1 enumeration to a boolean. (Is it? This isn't an new histogram.)

[Alexei Svitkine (slow), 2014/08/24 15:49:20]

The two are equivalent in terms of what gets sent up.

+    }
+
     if (ssl_info.handshake_type == SSLInfo::HANDSHAKE_RESUME) {
       UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Resume_Handshake",
                                  connect_duration,