Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 493793003: Align SSLClientSocketOpenSSL and SSLClientSocketNSS histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.h » ('j') | net/socket/ssl_client_socket_openssl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 92af627b7f871e3edc19ae201c9da6919fc0a5ee..7231c77e9444c5a91bd5be12d55e52921ca099d7 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -2456,26 +2456,6 @@ void SSLClientSocketNSS::Core::UpdateConnectionStatus() {
VLOG(1) << "The server " << host_and_port_.ToString()
<< " does not support the TLS renegotiation_info extension.";
}
- UMA_HISTOGRAM_ENUMERATION("Net.RenegotiationExtensionSupported",
- peer_supports_renego_ext, 2);
-
- // We would like to eliminate fallback to SSLv3 for non-buggy servers
- // because of security concerns. For example, Google offers forward
- // secrecy with ECDHE but that requires TLS 1.0. An attacker can block
- // TLSv1 connections and force us to downgrade to SSLv3 and remove forward
- // secrecy.
- //
- // Yngve from Opera has suggested using the renegotiation extension as an
- // indicator that SSLv3 fallback was mistaken:
- // tools.ietf.org/html/draft-pettersen-tls-version-rollback-removal-00 .
- //
- // As a first step, measure how often clients perform version fallback
- // while the server advertises support secure renegotiation.
- if (ssl_config_.version_fallback &&
- channel_info.protocolVersion == SSL_LIBRARY_VERSION_3_0) {
- UMA_HISTOGRAM_BOOLEAN("Net.SSLv3FallbackToRenegoPatchedServer",
- peer_supports_renego_ext == PR_TRUE);
Ryan Sleevi 2014/08/20 19:58:12 Adam should comment on this. I think I'm fine remo
agl 2014/08/22 18:26:32 LGTM. I don't that we need to worry about this any
- }
}
if (ssl_config_.version_fallback) {
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.h » ('j') | net/socket/ssl_client_socket_openssl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698