Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 493783002: Oilpan: fix build after r180653. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r180653. Need an explicit RawPtr<> conversion to resolve toV8() overloading. TBR=oilpan-reviews BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-20 18:20:42 UTC) #1
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-20 18:21:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/493783002/1
6 years, 4 months ago (2014-08-20 18:21:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (1) as 180671
6 years, 4 months ago (2014-08-20 18:22:35 UTC) #4
haraken
6 years, 4 months ago (2014-08-21 00:52:34 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698