LayoutTests/fast/dom/custom/invalid-first-char-combinators.html - Issue 493713002: Invalid chars should not be allowed as first character in custom element name

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/custom/invalid-first-char-combinators.html

Issue 493713002: Invalid chars should not be allowed as first character in custom element name (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addrressing comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4

	5 <script>

	6 test(function () {

	7 var invalidCombinators = [ 0x0B83, 0x0F88, 0x0F89, 0x0F8A, 0x0F8B ];

	8

	9 for (var i = 0; i < invalidCombinators.length; i++) {

	10 var invalidCombinator = String.fromCharCode(invalidCombinators[i]) + '-x foo';

	11 assert_throws('SYNTAX_ERR', function () {

	12 document.registerElement(invalidCombinator);

	13 }, 'registering custom element: *' +

	14 invalidCombinator + '* should throw syntax error');

	15 }

	16

	17 }, 'registering invalid first letter combinators, not covered in Document::valid Names');
	dglazkov 2014/11/06 05:52:43 and here too? and here too? deepak.sa 2014/11/06 06:20:02 As the expected files for such test cases has been Show quoted text On 2014/11/06 05:52:43, dglazkov wrote: > and here too? As the expected files for such test cases has been removed earlier, *-expected file is not added here. Reference CL: https://codereview.chromium.org/332583002/
	18 </script>

OLD	NEW

« LayoutTests/fast/dom/custom/element-names.html ('K') | « LayoutTests/fast/dom/custom/element-names.html ('k') | Source/core/dom/custom/CustomElement.cpp » ('j') | no next file with comments »