Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5573)

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc

Issue 493643002: [SyncFS] Fix reaching NOTREACHED() in MetadataDatabase (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Work for a nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc
index 1ce143fdaa22683127b058d1b1b28b132d89c3ab..3ea2ef5cd7c6b9f1340b26f363bd2cba05926487 100644
--- a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc
+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc
@@ -485,6 +485,64 @@ TEST_F(MetadataDatabaseIndexOnDiskTest, TrackerIDSetByParentIDAndTitleTest) {
EXPECT_TRUE(multi_backing.title.empty()) << multi_backing.title;
}
+TEST_F(MetadataDatabaseIndexOnDiskTest,
+ TrackerIDSetByParentIDAndTitleTest_EmptyTitle) {
+ CreateTestDatabase(true, NULL);
+
+ const int64 kFolderTrackerID = 23;
+ const int64 kNewFileTrackerID = 42;
+ {
+ FileTracker app_root_tracker;
+ EXPECT_TRUE(index()->GetFileTracker(kAppRootTrackerID, &app_root_tracker));
+ scoped_ptr<FileMetadata> folder_metadata =
+ test_util::CreateFolderMetadata("folder_id", "folder_name");
+ scoped_ptr<FileTracker> folder_tracker =
+ test_util::CreateTracker(*folder_metadata, kFolderTrackerID,
+ &app_root_tracker);
+ index()->StoreFileMetadata(folder_metadata.Pass());
+ index()->StoreFileTracker(folder_tracker.Pass());
+ WriteToDB();
+ }
+
+ FileTracker folder_tracker;
+ EXPECT_TRUE(index()->GetFileTracker(kFolderTrackerID, &folder_tracker));
+ scoped_ptr<FileMetadata> metadata =
+ test_util::CreateFileMetadata("file_id2", std::string(), "md5_2");
+
+ // Testing GetFileTrackerIDsByFileID
+ TrackerIDSet tracker_ids = index()->GetFileTrackerIDsByParentAndTitle(
+ kFolderTrackerID, std::string());
+ EXPECT_TRUE(tracker_ids.empty());
+
+ // Testing AddToFileIDIndexes
+ scoped_ptr<FileTracker> file_tracker =
+ test_util::CreateTracker(*metadata, kNewFileTrackerID, &folder_tracker);
+
+ index()->StoreFileTracker(file_tracker.Pass());
+ WriteToDB();
+ tracker_ids = index()->GetFileTrackerIDsByParentAndTitle(
+ kFolderTrackerID, std::string());
+ EXPECT_EQ(1U, tracker_ids.size());
+ EXPECT_EQ(kNewFileTrackerID, tracker_ids.active_tracker());
+
+ ParentIDAndTitle multi_backing = index()->PickMultiBackingFilePath();
+ EXPECT_EQ(kInvalidTrackerID, multi_backing.parent_id);
+
+ // Testing UpdateInFileIDIndexes
+ file_tracker =
+ test_util::CreateTracker(*metadata, kNewFileTrackerID, &folder_tracker);
+
+ index()->StoreFileTracker(file_tracker.Pass());
+ WriteToDB();
+ tracker_ids = index()->GetFileTrackerIDsByParentAndTitle(
+ kFolderTrackerID, std::string());
+ EXPECT_EQ(1U, tracker_ids.size());
+ EXPECT_EQ(kNewFileTrackerID, tracker_ids.active_tracker());
+
+ multi_backing = index()->PickMultiBackingFilePath();
+ EXPECT_EQ(kInvalidTrackerID, multi_backing.parent_id);
+}
+
TEST_F(MetadataDatabaseIndexOnDiskTest, TrackerIDSetDetailsTest) {
CreateTestDatabase(true, NULL);
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698