chrome/browser/extensions/api/declarative_content/content_action.h - Issue 493633003: Browser changes for wiring up RequestContentScript API to shared memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_action.h

Issue 493633003: Browser changes for wiring up RequestContentScript API to shared memory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nit: Inline methods in unit tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc ('k') | chrome/browser/extensions/api/declarative_content/content_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_action.h

diff --git a/chrome/browser/extensions/api/declarative_content/content_action.h b/chrome/browser/extensions/api/declarative_content/content_action.h

index 347cf53e86a47956373354367c6e66c7847753b5..ab191c3e2c174f9316efc34366023a3aa6d0ada1 100644

--- a/chrome/browser/extensions/api/declarative_content/content_action.h

+++ b/chrome/browser/extensions/api/declarative_content/content_action.h

@@ -63,10 +63,12 @@ class ContentAction : public base::RefCounted<ContentAction> {

// Sets |error| and returns NULL in case of a semantic error that cannot

// be caught by schema validation. Sets |bad_message| and returns NULL

// in case the input is syntactically unexpected.

- static scoped_refptr<ContentAction> Create(const Extension* extension,

- const base::Value& json_action,

- std::string* error,

- bool* bad_message);

+ static scoped_refptr<ContentAction> Create(

+ content::BrowserContext* browser_context,

+ const Extension* extension,

+ const base::Value& json_action,

+ std::string* error,

+ bool* bad_message);

protected:

friend class base::RefCounted<ContentAction>;