chrome/browser/extensions/test_extension_system.h - Issue 493633003: Browser changes for wiring up RequestContentScript API to shared memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/test_extension_system.h

Issue 493633003: Browser changes for wiring up RequestContentScript API to shared memory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_content/content_action.h ('K') | « chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc ('k') | chrome/browser/extensions/user_script_loader.cc » ('j') | chrome/browser/extensions/user_script_loader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/test_extension_system.h

diff --git a/chrome/browser/extensions/test_extension_system.h b/chrome/browser/extensions/test_extension_system.h

index fb88ef3494ba724e146e78fde3a47998f4928e3e..f436c9fb5532fda3d4e99b2b609c9287151169b1 100644

--- a/chrome/browser/extensions/test_extension_system.h

+++ b/chrome/browser/extensions/test_extension_system.h

@@ -86,9 +86,10 @@ class TestExtensionSystem : public ExtensionSystem {

GetDeclarativeUserScriptMasterByExtension(

const ExtensionId& extension_id) OVERRIDE;

- // Note that you probably want to use base::RunLoop().RunUntilIdle() right

- // after this to run all the accumulated tasks.

- void SetReady() { ready_.Signal(); }

+ void SetReady() {

Devlin 2014/08/21 17:14:09 why this change?

Mark Dittmer 2014/08/21 21:25:12 Done.

+ LOG(INFO) << "SetReady()";

+ ready_.Signal();

+ }

// Factory method for tests to use with SetTestingProfile.

static KeyedService* Build(content::BrowserContext* profile);