Add an enrolling state for consumer management section in settings page.

chrome/browser/chromeos/policy/consumer_management_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/consumer_management_service.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/run_loop.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_process_platform_part.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/login/users/mock_user_manager.h"
 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/policy/device_cloud_policy_initializer.h"
 #include "chrome/browser/chromeos/policy/enrollment_status_chromeos.h"
 #include "chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.h"
+#include "chrome/browser/chromeos/settings/device_settings_test_helper.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/fake_profile_oauth2_token_service.h"
 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/browser_with_test_window_test.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "chromeos/dbus/cryptohome/rpc.pb.h"
 #include "chromeos/dbus/cryptohome_client.h"
 #include "chromeos/dbus/mock_cryptohome_client.h"
 #include "components/policy/core/common/cloud/device_management_service.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "components/signin/core/browser/signin_manager_base.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 #include "policy/proto/device_management_backend.pb.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::Invoke;
 using testing::NiceMock;
 using testing::Return;
 using testing::_;
 
+namespace em = enterprise_management;
+
 namespace {
 const char* kAttributeOwnerId = "consumer_management.owner_id";
 const char* kTestOwner = "test@chromium.org.test";
 }
 
 namespace policy {
 
 class ConsumerManagementServiceTest : public BrowserWithTestWindowTest {
  public:
   ConsumerManagementServiceTest()
-      : service_(new ConsumerManagementService(&mock_cryptohome_client_)),
+      : service_(new ConsumerManagementService(&mock_cryptohome_client_, NULL)),
         cryptohome_result_(false),
         set_owner_status_(false) {
     ON_CALL(mock_cryptohome_client_, GetBootAttribute(_, _))
         .WillByDefault(
             Invoke(this, &ConsumerManagementServiceTest::MockGetBootAttribute));
     ON_CALL(mock_cryptohome_client_, SetBootAttribute(_, _))
         .WillByDefault(
             Invoke(this, &ConsumerManagementServiceTest::MockSetBootAttribute));
     ON_CALL(mock_cryptohome_client_, FlushAndSignBootAttributes(_, _))
         .WillByDefault(
@@ skipping 49 matching lines @@
   }
 
   void OnGetOwnerDone(const std::string& owner) {
     owner_ = owner;
   }
 
   void OnSetOwnerDone(bool status) {
     set_owner_status_ = status;
   }
 
+  // Variables for building the service.
   NiceMock<chromeos::MockCryptohomeClient> mock_cryptohome_client_;
   scoped_ptr<ConsumerManagementService> service_;
 
   scoped_ptr<TestingProfileManager> testing_profile_manager_;
+
+  // Variables for setting the return value or catching the arguments of mock
+  // functions.
   chromeos::DBusMethodCallStatus cryptohome_status_;
   bool cryptohome_result_;
   cryptohome::BaseReply cryptohome_reply_;
   cryptohome::GetBootAttributeRequest get_boot_attribute_request_;
   cryptohome::SetBootAttributeRequest set_boot_attribute_request_;
-
   std::string owner_;
   bool set_owner_status_;
 };
 
 TEST_F(ConsumerManagementServiceTest, CanGetEnrollmentState) {
   EXPECT_EQ(ConsumerManagementService::ENROLLMENT_NONE,
             service_->GetEnrollmentState());
 
   SetEnrollmentState(ConsumerManagementService::ENROLLMENT_REQUESTED);
 
@@ skipping 52 matching lines @@
   cryptohome_status_ = chromeos::DBUS_METHOD_CALL_FAILURE;
   cryptohome_result_ = false;
 
   service_->SetOwner(kTestOwner,
                      base::Bind(&ConsumerManagementServiceTest::OnSetOwnerDone,
                                 base::Unretained(this)));
 
   EXPECT_FALSE(set_owner_status_);
 }
 
+TEST_F(ConsumerManagementServiceTest, IsEnrollingWorks) {
+  SetEnrollmentState(ConsumerManagementService::ENROLLMENT_NONE);
+  EXPECT_FALSE(service_->IsEnrolling());
+
+  SetEnrollmentState(ConsumerManagementService::ENROLLMENT_REQUESTED);
+  EXPECT_TRUE(service_->IsEnrolling());
+
+  SetEnrollmentState(ConsumerManagementService::ENROLLMENT_OWNER_STORED);
+  EXPECT_TRUE(service_->IsEnrolling());
+
+  SetEnrollmentState(ConsumerManagementService::ENROLLMENT_SUCCESS);
+  EXPECT_FALSE(service_->IsEnrolling());
+
+  SetEnrollmentState(ConsumerManagementService::ENROLLMENT_CANCELED);
+  EXPECT_FALSE(service_->IsEnrolling());
+}
+
+class ConsumerManagementServiceSettingsTest
+    : public chromeos::DeviceSettingsTestBase {
+ public:
+  ConsumerManagementServiceSettingsTest()
+        : service_(new ConsumerManagementService(
+              NULL, &device_settings_service_)) {
+  }
+
+  void SetManagementMode(em::PolicyData::ManagementMode mode) {
+    device_policy_.policy_data().set_management_mode(mode);

[bartfab (slow), 2014/08/20 14:40:02]

Nit: #include "chrome/browser/chromeos/policy/device_policy_builder.h"

[davidyu, 2014/08/21 09:40:29]

Done.

+    device_policy_.Build();
+    device_settings_test_helper_.set_policy_blob(device_policy_.GetBlob());
+    ReloadDeviceSettings();
+  }
+
+  NiceMock<chromeos::MockCryptohomeClient> mock_cryptohome_client_;
+  scoped_ptr<ConsumerManagementService> service_;

[bartfab (slow), 2014/08/20 14:40:02]

Nit: #include "base/memory/scoped_ptr.h"

[davidyu, 2014/08/21 09:40:29]

Done.

+};
+
+TEST_F(ConsumerManagementServiceSettingsTest, IsEnrolledWorks) {
+  SetManagementMode(em::PolicyData::NOT_MANAGED);
+  EXPECT_FALSE(service_->IsEnrolled());
+
+  SetManagementMode(em::PolicyData::ENTERPRISE_MANAGED);
+  EXPECT_FALSE(service_->IsEnrolled());
+
+  SetManagementMode(em::PolicyData::CONSUMER_MANAGED);
+  EXPECT_TRUE(service_->IsEnrolled());
+}
+
 class ConsumerManagementServiceEnrollmentTest
     : public ConsumerManagementServiceTest {
  public:
   ConsumerManagementServiceEnrollmentTest()
       : mock_user_manager_(new NiceMock<chromeos::MockUserManager>()),
         scoped_user_manager_enabler_(mock_user_manager_),
         fake_initializer_(new FakeDeviceCloudPolicyInitializer()),
         enrollment_status_(EnrollmentStatus::ForStatus(
             EnrollmentStatus::STATUS_SUCCESS)) {
     // Set up MockUserManager. The first user will be the owner.
@@ skipping 131 matching lines @@
   EXPECT_FALSE(HasEnrollmentNotification());
 
   RunEnrollmentTest();
 
   EXPECT_FALSE(fake_initializer_->is_start_enrollment_called());
   EXPECT_EQ(ConsumerManagementService::ENROLLMENT_NONE, GetEnrollmentState());
   EXPECT_TRUE(HasEnrollmentNotification());
 }
 
 }  // namespace policy