Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 493603003: sandbox: Update known syscalls to kernel 3.17 (Closed)

Created:
6 years, 4 months ago by leecam
Modified:
6 years, 4 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

sandbox: Update known syscalls to kernel 3.17 Updated Arm, Mips, x86_32 and x86_64 syscall defines to match the latest kernel 3.17 at the time of this commit. BUG=406123 TEST=sandbox_linux_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291315

Patch Set 1 #

Total comments: 3

Patch Set 2 : disallow seccomp #

Total comments: 2

Patch Set 3 : fixed nit #

Patch Set 4 : move seccomp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -2 lines) Patch
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc View 1 2 7 chunks +19 lines, -2 lines 0 comments Download
M sandbox/linux/services/arm_linux_syscalls.h View 1 chunk +32 lines, -0 lines 0 comments Download
M sandbox/linux/services/mips_linux_syscalls.h View 1 chunk +16 lines, -0 lines 0 comments Download
M sandbox/linux/services/x86_32_linux_syscalls.h View 1 chunk +28 lines, -0 lines 0 comments Download
M sandbox/linux/services/x86_64_linux_syscalls.h View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
leecam
Had a chat with Robert and we decided to split the syscall defining from https://codereview.chromium.org/487143003/ ...
6 years, 4 months ago (2014-08-21 22:23:12 UTC) #1
jln (very slow on Chromium)
lgtm with a small nit. https://chromiumcodereview.appspot.com/493603003/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc File sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc (right): https://chromiumcodereview.appspot.com/493603003/diff/1/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc#newcode849 sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc:849: case __NR_sched_setattr: Please, alphabetize.
6 years, 4 months ago (2014-08-21 23:36:05 UTC) #2
jln (very slow on Chromium)
Oops, I read a bit too fast. Not lgtm, since I don't think we should ...
6 years, 4 months ago (2014-08-21 23:38:01 UTC) #3
leecam
Fixed it up... https://codereview.chromium.org/493603003/diff/1/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc File sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc (right): https://codereview.chromium.org/493603003/diff/1/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc#newcode56 sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc:56: SyscallSets::IsSeccomp(sysno); Yeah I guess once its ...
6 years, 4 months ago (2014-08-21 23:57:13 UTC) #4
jln (very slow on Chromium)
lgtm with minor nits. https://chromiumcodereview.appspot.com/493603003/diff/20001/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc File sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc (right): https://chromiumcodereview.appspot.com/493603003/diff/20001/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc#newcode167 sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc:167: return Error(EPERM); I know that ...
6 years, 4 months ago (2014-08-22 00:05:17 UTC) #5
leecam
The CQ bit was checked by leecam@chromium.org
6 years, 4 months ago (2014-08-22 00:07:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leecam@chromium.org/493603003/60001
6 years, 4 months ago (2014-08-22 00:09:15 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 02:02:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (60001) as 291315

Powered by Google App Engine
This is Rietveld 408576698