Fix JingleSession class to avoid bogus incompatible protocol error

Fix JingleSession class to avoid bogus incompatible protocol error

Two issues fixed in the error message handling code:
 1. Error response to session-info message is interpreted as old peer
    that doesn't support current auth protocol. That's not necessary
    anymore.
 2. Errors received after session-terminate were not ignored as they
    should.

BUG=402735
Committed: https://crrev.com/8fbaaa3b0cde0b4a96ef105814e76b3d9ab0d430
Cr-Commit-Position: refs/heads/master@{#291730}

[Wez, 2014-08-20 01:45:24]

lgtm

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
File remoting/protocol/jingle_session.cc (left):

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
remoting/protocol/jingle_session.cc:369: CloseInternal(INCOMPATIBLE_PROTOCOL);
Does this mean we can't ever return INCOMPATIBLE_PROTOCOL now?

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
File remoting/protocol/jingle_session.cc (right):

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
remoting/protocol/jingle_session.cc:351: // Ignore all responses after session
was closed.
nit: Suggest moving this comment outside the if()

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
remoting/protocol/jingle_session.cc:371: // here. Parse the response stanza to
find failure reason.
nit: Please file a bug for that work and add a link here. :)

[Sergey Ulanov, 2014-08-25 17:28:08]

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
File remoting/protocol/jingle_session.cc (left):

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
remoting/protocol/jingle_session.cc:369: CloseInternal(INCOMPATIBLE_PROTOCOL);
On 2014/08/20 01:45:23, Wez wrote:
> Does this mean we can't ever return INCOMPATIBLE_PROTOCOL now?

No, there are some placed where INCOMPATIBLE_PROTOCOL is still used.

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
File remoting/protocol/jingle_session.cc (right):

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
remoting/protocol/jingle_session.cc:351: // Ignore all responses after session
was closed.
On 2014/08/20 01:45:23, Wez wrote:
> nit: Suggest moving this comment outside the if()

Done.

https://codereview.chromium.org/493573002/diff/1/remoting/protocol/jingle_ses...
remoting/protocol/jingle_session.cc:371: // here. Parse the response stanza to
find failure reason.
On 2014/08/20 01:45:23, Wez wrote:
> nit: Please file a bug for that work and add a link here. :)

This is not a new TODO. I don't think we need a bug for it as it's not something
that will get fixed unless there is a specific error case that we need to handle

[Sergey Ulanov, 2014-08-25 17:29:21]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2014-08-25 17:29:51]

The CQ bit was unchecked by sergeyu@chromium.org

[Sergey Ulanov, 2014-08-25 17:30:34]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-08-25 17:31:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyu@chromium.org/493573002/40001

[commit-bot: I haz the power, 2014-08-25 18:26:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-25 19:09:10]

Committed patchset #3 (40001) as f5471b4a0ec33fa3e2643322161a4c420a79b6c5

[commit-bot: I haz the power, 2014-09-10 02:36:28]

Patchset 3 (id:??) landed as
https://crrev.com/8fbaaa3b0cde0b4a96ef105814e76b3d9ab0d430
Cr-Commit-Position: refs/heads/master@{#291730}