minidump/minidump_module_writer_test.cc - Issue 493563002: Add CaptureContext and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_module_writer_test.cc

Issue 493563002: Add CaptureContext and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_module_writer_test.cc

diff --git a/minidump/minidump_module_writer_test.cc b/minidump/minidump_module_writer_test.cc

index 5b47e017abff54031fab8eea74b3c74133566060..296de79369a721ac01875256b62a5a936087ff30 100644

--- a/minidump/minidump_module_writer_test.cc

+++ b/minidump/minidump_module_writer_test.cc

@@ -132,7 +132,8 @@ void ExpectCodeViewRecord(const MINIDUMP_LOCATION_DESCRIPTOR* codeview_record,

&file_contents[codeview_record->Rva]);

EXPECT_EQ(MinidumpModuleCodeViewRecordPDB20::kSignature,

codeview_pdb20_record->signature);

- EXPECT_EQ(expected_pdb_timestamp, codeview_pdb20_record->timestamp);

+ EXPECT_EQ(static_cast<uint32_t>(expected_pdb_timestamp),

Robert Sesek 2014/08/20 22:02:58 This is unrelated.

Mark Mentovai 2014/08/20 22:23:37 rsesek wrote:

+ codeview_pdb20_record->timestamp);

EXPECT_EQ(expected_pdb_age, codeview_pdb20_record->age);

observed_pdb_name.assign(

« client/capture_context_mac.S ('K') | « crashpad.gyp ('k') | no next file » | no next file with comments »