Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: chrome/browser/ui/app_list/search/people/people_provider.cc

Issue 49353006: Add caching for apps list search results. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/people/people_provider.cc
diff --git a/chrome/browser/ui/app_list/search/people/people_provider.cc b/chrome/browser/ui/app_list/search/people/people_provider.cc
index 4a9f668345c07abde716d126166b82fe6e87eb46..b999034e7df1c64563433ab072f5b87caab305a0 100644
--- a/chrome/browser/ui/app_list/search/people/people_provider.cc
+++ b/chrome/browser/ui/app_list/search/people/people_provider.cc
@@ -58,14 +58,17 @@ void PeopleProvider::Start(const base::string16& query) {
}
query_ = UTF16ToUTF8(query);
- const base::DictionaryValue* cached_result = cache_.Get(query_);
- if (cached_result) {
- ProcessPeopleSearchResults(cached_result);
+
+ const CacheResult result = cache_->Get(WebserviceCache::PEOPLE, query_);
+ if (result.second) {
+ ProcessPeopleSearchResults(result.second);
if (!people_search_fetched_callback_.is_null())
people_search_fetched_callback_.Run();
- return;
+ if (result.first == FRESH)
+ return;
}
+
if (!people_search_) {
people_search_.reset(new JSONResponseFetcher(
base::Bind(&PeopleProvider::OnPeopleSearchFetched,
@@ -143,7 +146,7 @@ void PeopleProvider::StartQuery() {
void PeopleProvider::OnPeopleSearchFetched(
scoped_ptr<base::DictionaryValue> json) {
ProcessPeopleSearchResults(json.get());
- cache_.Put(query_, json.Pass());
+ cache_->Put(WebserviceCache::PEOPLE, query_, json.Pass());
if (!people_search_fetched_callback_.is_null())
people_search_fetched_callback_.Run();

Powered by Google App Engine
This is Rietveld 408576698