Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/telemetry/telemetry/page/test_expectations_unittest.py

Issue 49353004: Added ability to set telemetry expectations against test names as well as URLs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/test_expectations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/test_expectations_unittest.py
diff --git a/tools/telemetry/telemetry/page/test_expectations_unittest.py b/tools/telemetry/telemetry/page/test_expectations_unittest.py
index 20ffcb3c9c1606533922bca67349c61c7d72b4f7..53314dbcd7ca0fc1bb1b9ae2cff694623328917e 100644
--- a/tools/telemetry/telemetry/page/test_expectations_unittest.py
+++ b/tools/telemetry/telemetry/page/test_expectations_unittest.py
@@ -58,6 +58,7 @@ class SampleTestExpectations(test_expectations.TestExpectations):
self.Fail('page8.html', ['win', 'intel', ('amd', 0x1001)], bug=123)
self.Fail('page9.html', ['imagination'])
self.Fail('page10.html', [('imagination', 'PowerVR SGX 554')])
+ self.Fail('Pages.page_11')
class TestExpectationsTest(unittest.TestCase):
def setUp(self):
@@ -181,3 +182,10 @@ class TestExpectationsTest(unittest.TestCase):
self.assertExpectationEquals('pass', page,
vendor_string='Acme',
device_string=DEVICE_STRING_SGX)
+
+ # Expectations can be set against page names as well as urls
+ def testPageNameExpectations(self):
+ ps = page_set.PageSet()
+ page = page_module.Page('http://test.com/page11.html', ps)
+ page.name = "Pages.page_11"
+ self.assertExpectationEquals('fail', page)
« no previous file with comments | « tools/telemetry/telemetry/page/test_expectations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698