Issue 493493004: Add GN substitution support for Ninja's $in_newline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 493493004: Add GN substitution support for Ninja's $in_newline (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
jamesr

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -0 lines)			Patch
M	tools/gn/function_toolchain.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tools/gn/substitution_type.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/substitution_type.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 4 months ago (2014-08-19 23:51:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as 290700 (presubmit successful).